From b42460c2c32a5b24a3f344121876534e61399140 Mon Sep 17 00:00:00 2001 From: Paul DiPietro Date: Tue, 12 Apr 2016 12:30:27 -0700 Subject: [PATCH] Enable CS1998 warnings as errors (#65) --- .../Bugzilla27350.cs | 2 ++ .../Bugzilla31114.cs | 2 ++ .../Bugzilla39821.cs | 8 ++++++++ .../Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs | 2 +- .../Xamarin.Forms.Controls.Issues.Shared/Issue1758.cs | 2 +- .../Xamarin.Forms.Controls.Issues.Shared/Issue1875.cs | 2 ++ .../Issue2357.xaml.cs | 2 ++ .../Issue3319.xaml.cs | 4 ++++ .../ControlGalleryPages/AutomationIDGallery.cs | 4 ++-- Xamarin.Forms.Controls/Xamarin.Forms.Controls.csproj | 6 +++--- .../Xamarin.Forms.Core.Android.UITests.csproj | 6 +++--- .../Xamarin.Forms.Core.Windows.UITests.csproj | 4 ++-- .../Xamarin.Forms.Core.iOS.UITests.csproj | 6 +++--- .../AppCompat/NavigationPageRenderer.cs | 4 +++- .../Xamarin.Forms.Platform.Android.csproj | 7 +++---- .../Xamarin.Forms.Platform.UAP.csproj | 16 ++++++++-------- Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs | 2 ++ Xamarin.Forms.Platform.WinRT/NavigationPageRenderer.cs | 2 ++ Xamarin.Forms.Platform.WinRT/Platform.cs | 2 ++ .../Xamarin.Forms.Platform.WinRT.csproj | 4 ++-- Xamarin.Forms.Xaml.UnitTests/EventsConnection.xaml.cs | 2 ++ .../Xamarin.Forms.Xaml.UnitTests.csproj | 6 +++--- 22 files changed, 62 insertions(+), 33 deletions(-) diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27350.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27350.cs index e489935..a705fdd 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27350.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27350.cs @@ -30,7 +30,9 @@ namespace Xamarin.Forms.Controls public ObservableCollection RecipeGroups { get; set; } +#pragma warning disable 1998 // considered for removal public async Task LoadRecipesAsync () +#pragma warning restore 1998 { var groups = new ObservableCollection (); groups.Add (new RecipeGroup { Title = "Teste 1" }); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31114.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31114.cs index 8f56fdb..16d4afa 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31114.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31114.cs @@ -377,7 +377,9 @@ namespace Xamarin.Forms.Controls } } +#pragma warning disable 1998 // considered for removal async void FastCompleteForCmd(object sender) +#pragma warning restore 1998 { try { diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39821.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39821.cs index ab998d0..4a3ed1d 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39821.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39821.cs @@ -59,7 +59,9 @@ namespace Xamarin.Forms.Controls.Issues }; } +#pragma warning disable 1998 // considered for removal async Task CheckTranslateRunning(BoxView box) +#pragma warning restore 1998 { Debug.WriteLine(box.AnimationIsRunning("TranslateTo") ? "Translate is running" : "Translate is not running"); } @@ -84,18 +86,24 @@ namespace Xamarin.Forms.Controls.Issues await box.RelRotateTo(360); } +#pragma warning disable 1998 // considered for removal async Task Cancel(BoxView box) +#pragma warning restore 1998 { box.AbortAnimation("animate"); box.AbortAnimation("kinetic"); } +#pragma warning disable 1998 // considered for removal async Task Animate(BoxView box) +#pragma warning restore 1998 { box.Animate("animate", d => d, d => { }, 100, 1); } +#pragma warning disable 1998 // considered for removal async Task Kinetic(BoxView box) +#pragma warning restore 1998 { var resultList = new List>(); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs index 2ad7025..edb6683 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs @@ -278,7 +278,7 @@ namespace Xamarin.Forms.Controls try { IsPresented = !IsPresented; } catch (InvalidOperationException ex) { - DisplayAlert ("Error", ex.Message, "ok"); + await DisplayAlert ("Error", ex.Message, "ok"); } } diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1758.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1758.cs index 7cb392f..ebd9f64 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1758.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1758.cs @@ -63,7 +63,7 @@ namespace Xamarin.Forms.Controls // Comment this delay out to see the bug // await Task.Delay(500); - _button.LayoutTo(new Rectangle(100, 100, 100, 100), 1000); + await _button.LayoutTo(new Rectangle(100, 100, 100, 100), 1000); } } } \ No newline at end of file diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1875.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1875.cs index 0391ef4..09e5eca 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1875.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1875.cs @@ -92,7 +92,9 @@ namespace Xamarin.Forms.Controls } } +#pragma warning disable 1998 // considered for removal public async Task LoadData (int start, int numberOfRecords) +#pragma warning restore 1998 { IsLoading = true; for (int counter = 0; counter < numberOfRecords; counter++) diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2357.xaml.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2357.xaml.cs index 54c8e0b..99b85b7 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2357.xaml.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2357.xaml.cs @@ -210,7 +210,9 @@ namespace Xamarin.Forms.Controls _mainMenuItems = new ObservableCollection (Enumerable.Empty ()); } +#pragma warning disable 1998 // considered for removal public async Task InitializeAsync () +#pragma warning restore 1998 { var items = new List (); items.Add (new MainMenuItem { diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3319.xaml.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3319.xaml.cs index d2f54cd..0459319 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3319.xaml.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3319.xaml.cs @@ -56,7 +56,9 @@ namespace Xamarin.Forms.Controls } +#pragma warning disable 1998 // considered for removal public async void OnDelete (object sender, EventArgs e) +#pragma warning restore 1998 { var mi = ((MenuItem)sender); if (mi.CommandParameter == null) @@ -105,7 +107,9 @@ namespace Xamarin.Forms.Controls } } +#pragma warning disable 1998 // considered for removal public async Task ExecuteFavoritesCommand () +#pragma warning restore 1998 { if (IsBusy) return; diff --git a/Xamarin.Forms.Controls/ControlGalleryPages/AutomationIDGallery.cs b/Xamarin.Forms.Controls/ControlGalleryPages/AutomationIDGallery.cs index c93a9b6..4ba2666 100644 --- a/Xamarin.Forms.Controls/ControlGalleryPages/AutomationIDGallery.cs +++ b/Xamarin.Forms.Controls/ControlGalleryPages/AutomationIDGallery.cs @@ -43,7 +43,7 @@ namespace Xamarin.Forms.Controls var btn = new Button { AutomationId = "popModal", Text = "Pop", - Command = new Command (async () => Navigation.PopModalAsync ()) + Command = new Command (async () => await Navigation.PopModalAsync ()) }; rootLayout.Children.Add (btn); rootLayout.Children.Add (new ActivityIndicator { AutomationId = "actHello", IsRunning = true }); @@ -72,7 +72,7 @@ namespace Xamarin.Forms.Controls var btn = new Button { AutomationId = "popModal", Text = "Pop", - Command = new Command (async () => Navigation.PopModalAsync ()) + Command = new Command (async () => await Navigation.PopModalAsync ()) }; rootLayout.Children.Add (btn); rootLayout.Children.Add (new Image { AutomationId = "imgHello", Source = "menuIcon" }); diff --git a/Xamarin.Forms.Controls/Xamarin.Forms.Controls.csproj b/Xamarin.Forms.Controls/Xamarin.Forms.Controls.csproj index 05a7b5f..b5dd6af 100644 --- a/Xamarin.Forms.Controls/Xamarin.Forms.Controls.csproj +++ b/Xamarin.Forms.Controls/Xamarin.Forms.Controls.csproj @@ -28,7 +28,7 @@ prompt 4 true - 0114;0108;0109;4014;1998;0649;0169;0472;0414;0168;0219;0429 + 0114;0108;0109;4014;0649;0169;0472;0414;0168;0219;0429 pdbonly @@ -38,7 +38,7 @@ prompt 4 true - 0114;0108;0109;4014;1998;0649;0169;0472;0414;0168;0219;0429 + 0114;0108;0109;4014;0649;0169;0472;0414;0168;0219;0429 true @@ -51,7 +51,7 @@ 4 false true - 0114;0108;0109;4014;1998;0649;0169;0472;0414;0168;0219;0429 + 0114;0108;0109;4014;0649;0169;0472;0414;0168;0219;0429 diff --git a/Xamarin.Forms.Core.Android.UITests/Xamarin.Forms.Core.Android.UITests.csproj b/Xamarin.Forms.Core.Android.UITests/Xamarin.Forms.Core.Android.UITests.csproj index b1cf107..19b578e 100644 --- a/Xamarin.Forms.Core.Android.UITests/Xamarin.Forms.Core.Android.UITests.csproj +++ b/Xamarin.Forms.Core.Android.UITests/Xamarin.Forms.Core.Android.UITests.csproj @@ -23,7 +23,7 @@ prompt 4 true - 0114;0108;4014;1998;0649;0168;0169;0219 + 0114;0108;4014;0649;0168;0169;0219 pdbonly @@ -33,7 +33,7 @@ prompt 4 true - 0114;0108;4014;1998;0649;0168;0169;0219 + 0114;0108;4014;0649;0168;0169;0219 true @@ -44,7 +44,7 @@ prompt MinimumRecommendedRules.ruleset true - 0114;0108;4014;1998;0649;0168;0169;0219 + 0114;0108;4014;0649;0168;0169;0219 diff --git a/Xamarin.Forms.Core.Windows.UITests/Xamarin.Forms.Core.Windows.UITests.csproj b/Xamarin.Forms.Core.Windows.UITests/Xamarin.Forms.Core.Windows.UITests.csproj index 17d6c0e..cb493ba 100644 --- a/Xamarin.Forms.Core.Windows.UITests/Xamarin.Forms.Core.Windows.UITests.csproj +++ b/Xamarin.Forms.Core.Windows.UITests/Xamarin.Forms.Core.Windows.UITests.csproj @@ -21,7 +21,7 @@ prompt 4 true - 0114;0108;4014;1998;0649;0169;0168;0219 + 0114;0108;4014;0649;0169;0168;0219 pdbonly @@ -31,7 +31,7 @@ prompt 4 true - 0114;0108;4014;1998;0649;0169;0168;0219 + 0114;0108;4014;0649;0169;0168;0219 diff --git a/Xamarin.Forms.Core.iOS.UITests/Xamarin.Forms.Core.iOS.UITests.csproj b/Xamarin.Forms.Core.iOS.UITests/Xamarin.Forms.Core.iOS.UITests.csproj index 085c221..530f366 100644 --- a/Xamarin.Forms.Core.iOS.UITests/Xamarin.Forms.Core.iOS.UITests.csproj +++ b/Xamarin.Forms.Core.iOS.UITests/Xamarin.Forms.Core.iOS.UITests.csproj @@ -23,7 +23,7 @@ prompt 4 true - 0114;0108;4014;1998;0649;0169;0168;0219 + 0114;0108;4014;0649;0169;0168;0219 pdbonly @@ -33,7 +33,7 @@ prompt 4 true - 0114;0108;4014;1998;0649;0169;0168;0219 + 0114;0108;4014;0649;0169;0168;0219 true @@ -44,7 +44,7 @@ prompt MinimumRecommendedRules.ruleset true - 0114;0108;4014;1998;0649;0169;0168;0219 + 0114;0108;4014;0649;0169;0168;0219 4 diff --git a/Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs b/Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs index 7fd4ed9..b93a0eb 100644 --- a/Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs +++ b/Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs @@ -362,7 +362,9 @@ namespace Xamarin.Forms.Platform.Android.AppCompat UpdateToolbar(); } - void DeviceInfoPropertyChanged(object sender, PropertyChangedEventArgs e) +#pragma warning disable 1998 // considered for removal + async void DeviceInfoPropertyChanged(object sender, PropertyChangedEventArgs e) +#pragma warning restore 1998 { if (nameof(Device.Info.CurrentOrientation) == e.PropertyName) ResetToolbar(); diff --git a/Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj b/Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj index 2ec3ccc..da51f29 100644 --- a/Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj +++ b/Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj @@ -28,8 +28,7 @@ prompt 4 true - - + 0642;0114;0108;0672;0168;0169;0184;0649;0414 pdbonly @@ -39,7 +38,7 @@ prompt 4 true - 0642;0114;0108;0672;0168;0169;0184;0649;1998;0414 + 0642;0114;0108;0672;0168;0169;0184;0649;0414 true @@ -51,7 +50,7 @@ prompt MinimumRecommendedRules.ruleset true - 0642;0114;0108;0672;0168;0169;0184;0649;1998;0414 + 0642;0114;0108;0672;0168;0169;0184;0649;0414 diff --git a/Xamarin.Forms.Platform.UAP/Xamarin.Forms.Platform.UAP.csproj b/Xamarin.Forms.Platform.UAP/Xamarin.Forms.Platform.UAP.csproj index d0781af..bccb702 100644 --- a/Xamarin.Forms.Platform.UAP/Xamarin.Forms.Platform.UAP.csproj +++ b/Xamarin.Forms.Platform.UAP/Xamarin.Forms.Platform.UAP.csproj @@ -27,7 +27,7 @@ prompt 4 true - 1998 + AnyCPU @@ -38,14 +38,14 @@ prompt 4 true - 1998 + ARM true bin\ARM\Debug\ DEBUG;TRACE;NETFX_CORE;WINDOWS_UWP - 1998;0649;0169;0067 + 0649;0169;0067 full ARM false @@ -58,7 +58,7 @@ bin\ARM\Release\ TRACE;NETFX_CORE;WINDOWS_UWP true - 1998;0649;0169;0067 + 0649;0169;0067 pdbonly ARM false @@ -71,7 +71,7 @@ true bin\x64\Debug\ DEBUG;TRACE;NETFX_CORE;WINDOWS_UWP - 1998;0649;0169;0067 + 0649;0169;0067 full x64 false @@ -84,7 +84,7 @@ bin\x64\Release\ TRACE;NETFX_CORE;WINDOWS_UWP true - 1998;0649;0169;0067 + 0649;0169;0067 pdbonly x64 false @@ -97,7 +97,7 @@ true bin\x86\Debug\ DEBUG;TRACE;NETFX_CORE;WINDOWS_UWP - 1998;0649;0169;0067 + 0649;0169;0067 full x86 false @@ -110,7 +110,7 @@ bin\x86\Release\ TRACE;NETFX_CORE;WINDOWS_UWP true - 1998;0649;0169;0067 + 0649;0169;0067 pdbonly x86 false diff --git a/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs b/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs index 05e3f93..bbd101f 100644 --- a/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs +++ b/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs @@ -278,7 +278,9 @@ namespace Xamarin.Forms.Platform.WinRT ScrollTo(til.ListProxy.ProxiedEnumerable, til.ListProxy[0], ScrollToPosition.Start, true, true); } +#pragma warning disable 1998 // considered for removal async void ScrollTo(object group, object item, ScrollToPosition toPosition, bool shouldAnimate, bool includeGroup = false, bool previouslyFailed = false) +#pragma warning restore 1998 { ScrollViewer viewer = GetScrollViewer(); if (viewer == null) diff --git a/Xamarin.Forms.Platform.WinRT/NavigationPageRenderer.cs b/Xamarin.Forms.Platform.WinRT/NavigationPageRenderer.cs index 1e48d7e..8bcf207 100644 --- a/Xamarin.Forms.Platform.WinRT/NavigationPageRenderer.cs +++ b/Xamarin.Forms.Platform.WinRT/NavigationPageRenderer.cs @@ -496,7 +496,9 @@ namespace Xamarin.Forms.Platform.WinRT (this as ITitleProvider).BarForegroundBrush = GetBarForegroundBrush(); } +#pragma warning disable 1998 // considered for removal async void UpdateTitleOnParents() +#pragma warning restore 1998 { if (Element == null) return; diff --git a/Xamarin.Forms.Platform.WinRT/Platform.cs b/Xamarin.Forms.Platform.WinRT/Platform.cs index 012dd2c..4d7309d 100644 --- a/Xamarin.Forms.Platform.WinRT/Platform.cs +++ b/Xamarin.Forms.Platform.WinRT/Platform.cs @@ -493,7 +493,9 @@ namespace Xamarin.Forms.Platform.WinRT return GetCommandBarAsync(); } +#pragma warning disable 1998 // considered for removal async Task GetCommandBarAsync() +#pragma warning restore 1998 { #if !WINDOWS_UWP return _page.BottomAppBar as CommandBar; diff --git a/Xamarin.Forms.Platform.WinRT/Xamarin.Forms.Platform.WinRT.csproj b/Xamarin.Forms.Platform.WinRT/Xamarin.Forms.Platform.WinRT.csproj index 34a62fa..7f41e8b 100644 --- a/Xamarin.Forms.Platform.WinRT/Xamarin.Forms.Platform.WinRT.csproj +++ b/Xamarin.Forms.Platform.WinRT/Xamarin.Forms.Platform.WinRT.csproj @@ -37,7 +37,7 @@ prompt 4 true - 1998 + pdbonly @@ -47,7 +47,7 @@ prompt 4 true - 1998 + diff --git a/Xamarin.Forms.Xaml.UnitTests/EventsConnection.xaml.cs b/Xamarin.Forms.Xaml.UnitTests/EventsConnection.xaml.cs index 7bab567..5727693 100644 --- a/Xamarin.Forms.Xaml.UnitTests/EventsConnection.xaml.cs +++ b/Xamarin.Forms.Xaml.UnitTests/EventsConnection.xaml.cs @@ -64,7 +64,9 @@ namespace Xamarin.Forms.Xaml.UnitTests } int asyncPrivateClicked; +#pragma warning disable 1998 // considered for removal async void HandleClickedPrivateAsync (object sender, EventArgs e) +#pragma warning restore 1998 { asyncPrivateClicked++; } diff --git a/Xamarin.Forms.Xaml.UnitTests/Xamarin.Forms.Xaml.UnitTests.csproj b/Xamarin.Forms.Xaml.UnitTests/Xamarin.Forms.Xaml.UnitTests.csproj index 226e8bb..961774f 100644 --- a/Xamarin.Forms.Xaml.UnitTests/Xamarin.Forms.Xaml.UnitTests.csproj +++ b/Xamarin.Forms.Xaml.UnitTests/Xamarin.Forms.Xaml.UnitTests.csproj @@ -21,7 +21,7 @@ 4 false true - 0672;1998;0219;0414 + 0672;0219;0414 full @@ -31,7 +31,7 @@ 4 false true - 0672;1998;0219;0414 + 0672;0219;0414 true @@ -44,7 +44,7 @@ 4 false true - 0672;1998;0219;0414 + 0672;0219;0414 -- 2.7.4