From b40908e639b6075c77d7b2a990a2a273a39f4102 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Thu, 3 Jun 2021 00:06:45 -0700 Subject: [PATCH] [NFC][scudo] Avoid integer overflow in test releasePagesToOS may shrink RSS below the value stored on start. --- compiler-rt/lib/scudo/standalone/tests/common_test.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/compiler-rt/lib/scudo/standalone/tests/common_test.cpp b/compiler-rt/lib/scudo/standalone/tests/common_test.cpp index d8184a7..711e3b2 100644 --- a/compiler-rt/lib/scudo/standalone/tests/common_test.cpp +++ b/compiler-rt/lib/scudo/standalone/tests/common_test.cpp @@ -37,16 +37,16 @@ TEST(ScudoCommonTest, SKIP_ON_FUCHSIA(ResidentMemorySize)) { MapPlatformData Data = {}; void *P = map(nullptr, Size, "ResidentMemorySize", 0, &Data); ASSERT_NE(nullptr, P); - EXPECT_LT(getResidentMemorySize() - OnStart, Threshold); + EXPECT_LT(getResidentMemorySize(), OnStart + Threshold); memset(P, 1, Size); - EXPECT_GT(getResidentMemorySize() - OnStart, Size - Threshold); + EXPECT_GT(getResidentMemorySize(), OnStart + Size - Threshold); releasePagesToOS((uptr)P, 0, Size, &Data); - EXPECT_LT(getResidentMemorySize() - OnStart, Threshold); + EXPECT_LT(getResidentMemorySize(), OnStart + Threshold); memset(P, 1, Size); - EXPECT_GT(getResidentMemorySize() - OnStart, Size - Threshold); + EXPECT_GT(getResidentMemorySize(), OnStart + Size - Threshold); unmap(P, Size, 0, &Data); } -- 2.7.4