From b40149f5cb9c521c5d0826d7546e8753b0f08064 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Tue, 18 Jun 2019 21:00:55 +1000 Subject: [PATCH] test: fix initial coordinates for synaptics tripletap quirk I don't think there was a specific reason for the second touch point to jump around here either and the comment indicates it was just to avoid the clickfinger distance trigger. So let's just move the first touchpoint. Signed-off-by: Peter Hutterer --- test/test-touchpad.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/test/test-touchpad.c b/test/test-touchpad.c index 451cba9..e22fa6d 100644 --- a/test/test-touchpad.c +++ b/test/test-touchpad.c @@ -5357,8 +5357,8 @@ START_TEST(touchpad_tool_tripletap_touch_count) /* touch 2 down */ litest_event(dev, EV_ABS, ABS_MT_SLOT, 1); litest_event(dev, EV_ABS, ABS_MT_TRACKING_ID, 1); - litest_event(dev, EV_ABS, ABS_MT_POSITION_X, 2200); - litest_event(dev, EV_ABS, ABS_MT_POSITION_Y, 3200); + litest_event(dev, EV_ABS, ABS_MT_POSITION_X, 3500); + litest_event(dev, EV_ABS, ABS_MT_POSITION_Y, 3500); litest_event(dev, EV_ABS, ABS_MT_PRESSURE, 73); litest_event(dev, EV_KEY, BTN_TOOL_FINGER, 0); litest_event(dev, EV_KEY, BTN_TOOL_DOUBLETAP, 1); @@ -5382,11 +5382,7 @@ START_TEST(touchpad_tool_tripletap_touch_count) libinput_dispatch(li); msleep(2); - /* slot 2 reactivated: - * Note, slot is activated close enough that we don't accidentally - * trigger the clickfinger distance check, remains to be seen if - * that is true for real-world interaction. - */ + /* slot 2 reactivated */ litest_event(dev, EV_ABS, ABS_MT_SLOT, 0); litest_event(dev, EV_ABS, ABS_MT_POSITION_X, 4000); litest_event(dev, EV_ABS, ABS_MT_POSITION_Y, 4000); @@ -5467,8 +5463,8 @@ START_TEST(touchpad_tool_tripletap_touch_count_late) /* touch 2 and TRIPLETAP down */ litest_event(dev, EV_ABS, ABS_MT_SLOT, 1); litest_event(dev, EV_ABS, ABS_MT_TRACKING_ID, 1); - litest_event(dev, EV_ABS, ABS_MT_POSITION_X, 3200); - litest_event(dev, EV_ABS, ABS_MT_POSITION_Y, 3200); + litest_event(dev, EV_ABS, ABS_MT_POSITION_X, 3500); + litest_event(dev, EV_ABS, ABS_MT_POSITION_Y, 3500); litest_event(dev, EV_ABS, ABS_MT_PRESSURE, 73); litest_event(dev, EV_KEY, BTN_TOOL_FINGER, 0); litest_event(dev, EV_KEY, BTN_TOOL_TRIPLETAP, 1); @@ -5491,11 +5487,7 @@ START_TEST(touchpad_tool_tripletap_touch_count_late) libinput_dispatch(li); msleep(10); - /* slot 2 reactivated: - * Note, slot is activated close enough that we don't accidentally - * trigger the clickfinger distance check, remains to be seen if - * that is true for real-world interaction. - */ + /* slot 2 reactivated */ litest_event(dev, EV_ABS, ABS_MT_SLOT, 0); litest_event(dev, EV_ABS, ABS_MT_POSITION_X, 4000); litest_event(dev, EV_ABS, ABS_MT_POSITION_Y, 4000); -- 2.7.4