From b3fce1bd45f72cc9e55fb7431762e92e30fefcf1 Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Wed, 9 Jun 2021 11:03:15 +0100 Subject: [PATCH] libstdc++: Fix constraint on std::optional assignment [PR 100982] libstdc++-v3/ChangeLog: PR libstdc++/100982 * include/std/optional (optional::operator=(const optional&)): Fix value category used in is_assignable check. * testsuite/20_util/optional/assignment/100982.cc: New test. --- libstdc++-v3/include/std/optional | 2 +- .../testsuite/20_util/optional/assignment/100982.cc | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 libstdc++-v3/testsuite/20_util/optional/assignment/100982.cc diff --git a/libstdc++-v3/include/std/optional b/libstdc++-v3/include/std/optional index 415f8c4..0a67ce2 100644 --- a/libstdc++-v3/include/std/optional +++ b/libstdc++-v3/include/std/optional @@ -815,7 +815,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template enable_if_t<__and_v<__not_>, is_constructible<_Tp, const _Up&>, - is_assignable<_Tp&, _Up>, + is_assignable<_Tp&, const _Up&>, __not_<__converts_from_optional<_Tp, _Up>>, __not_<__assigns_from_optional<_Tp, _Up>>>, optional&> diff --git a/libstdc++-v3/testsuite/20_util/optional/assignment/100982.cc b/libstdc++-v3/testsuite/20_util/optional/assignment/100982.cc new file mode 100644 index 0000000..ae56525 --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/optional/assignment/100982.cc @@ -0,0 +1,17 @@ +// { dg-do compile { target c++17 } } + +#include + +struct U {}; + +struct T { + explicit T(const U&); + T& operator=(const U&); + T& operator=(U&&) = delete; +}; + +int main() { + std::optional opt1; + std::optional opt2; + opt2 = opt1; // PR libstdc++/100982 +} -- 2.7.4