From b3b01a043ca3897180319cea107e6ba101ae0570 Mon Sep 17 00:00:00 2001 From: sangho park Date: Tue, 27 Sep 2022 12:49:37 +0900 Subject: [PATCH] mv_3d: fix coverity issue [Version] : 0.23.28-0 [Issue type] : bug fix fix coverity DefectId 1612132, 1612134, 1612135 (Unchecked return value) Change-Id: Ib618ab460996f40572e8084b743954eb7fad20c1 Signed-off-by: sangho park --- mv_3d/3d/src/Mv3d.cpp | 8 ++++++-- packaging/capi-media-vision.spec | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/mv_3d/3d/src/Mv3d.cpp b/mv_3d/3d/src/Mv3d.cpp index 258307a..b63ad9a 100644 --- a/mv_3d/3d/src/Mv3d.cpp +++ b/mv_3d/3d/src/Mv3d.cpp @@ -410,13 +410,17 @@ namespace mv3d auto depthData = handle->mDfsAdaptor->getOutputData(); auto leftData = handle->mDfsAdaptor->getLeftData(); - mv_source_fill_by_buffer(handle->mInternalSource, + int ret = mv_source_fill_by_buffer(handle->mInternalSource, static_cast(leftData.data), leftData.width, leftData.height, leftData.stride * leftData.height, leftData.type == DFS_DATA_TYPE_UINT8C3 ? MEDIA_VISION_COLORSPACE_RGB888 : MEDIA_VISION_COLORSPACE_Y800); + if (MEDIA_VISION_ERROR_NONE != ret) { + LOGW("Errors were occurred during source filling %i", ret); + continue; + } handle->mDepthCallback( static_cast(handle->mInternalSource), static_cast(depthData.data), @@ -431,7 +435,7 @@ namespace mv3d handle->GetPointcloudFromSource(*input, depthData, p); mv_3d_pointcloud_h pcd = &p; - handle->mPointcloudCallback(static_cast(mInternalSource), + handle->mPointcloudCallback(static_cast(handle->mInternalSource), pcd, handle->mPointcloudUserData); auto pPcd = static_cast*>(p.pointcloud); diff --git a/packaging/capi-media-vision.spec b/packaging/capi-media-vision.spec index fdb9d02..bcc2f5d 100644 --- a/packaging/capi-media-vision.spec +++ b/packaging/capi-media-vision.spec @@ -1,6 +1,6 @@ Name: capi-media-vision Summary: Media Vision library for Tizen Native API -Version: 0.23.27 +Version: 0.23.28 Release: 0 Group: Multimedia/Framework License: Apache-2.0 and BSD-3-Clause -- 2.7.4