From b3a6883125a033bb0b419ad0a4a1e91303d84082 Mon Sep 17 00:00:00 2001 From: Denis Kenzior Date: Tue, 16 Mar 2010 17:41:26 -0500 Subject: [PATCH] Fix: Use g_try_malloc when parsing stk result --- src/stkutil.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/stkutil.c b/src/stkutil.c index afc92d6..940eee2 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -271,6 +271,7 @@ static gboolean parse_dataobj_result(struct comprehension_tlv_iter *iter, struct stk_result *result = user; const unsigned char *data; unsigned int len; + unsigned char *additional; if (comprehension_tlv_iter_get_tag(iter) != STK_DATA_OBJECT_TYPE_RESULT) @@ -288,9 +289,13 @@ static gboolean parse_dataobj_result(struct comprehension_tlv_iter *iter, (data[0] == 0x3c) || (data[0] == 0x3d))) return FALSE; + additional = g_try_malloc(len - 1); + if (additional == NULL) + return FALSE; + result->type = data[0]; result->additional_len = len - 1; - result->additional = g_malloc(len - 1); + result->additional = additional; memcpy(result->additional, data + 1, len - 1); return TRUE; -- 2.7.4