From b36708830b8a0e5c1166a882cba5bbe7afa966ca Mon Sep 17 00:00:00 2001 From: Deepika Aggarwal Date: Thu, 3 Dec 2015 11:22:56 +0530 Subject: [PATCH] Be explicit about enum comparison in bus_config_load() XML_Parse() can potentially return values other than OK (1) or ERROR (0), and they aren't errors. Signed-off-by: Deepika Aggarwal Bug: https://bugs.freedesktop.org/show_bug.cgi?id=93205 [smcv: improve commit message, fix whitespace] Reviewed-by: Simon McVittie --- bus/config-loader-expat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bus/config-loader-expat.c b/bus/config-loader-expat.c index b571fda..9019697 100644 --- a/bus/config-loader-expat.c +++ b/bus/config-loader-expat.c @@ -242,7 +242,7 @@ bus_config_load (const DBusString *file, data_str = _dbus_string_get_const_data (&data); - if (!XML_Parse (expat, data_str, _dbus_string_get_length (&data), TRUE)) + if (XML_Parse (expat, data_str, _dbus_string_get_length (&data), TRUE) == XML_STATUS_ERROR) { if (context.error != NULL && !dbus_error_is_set (context.error)) -- 2.7.4