From b2b810ebff657b3d24d93a1fdbd6adc79bc38153 Mon Sep 17 00:00:00 2001 From: Chia-I Wu Date: Thu, 17 Mar 2022 11:03:18 -0700 Subject: [PATCH] anv: advertise rectangularLines only for Gen10+ We use the non-strict algorithm (with parallelograms) prior to Gen10 for wide lines. We can not advertise rectangularLines. Signed-off-by: Chia-I Wu Fixes: f6e7de41d7b ("anv: Implement VK_EXT_line_rasterization") Reviewed-by: Ivan Briano Part-of: --- src/intel/vulkan/anv_device.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index d67eb0b..90ca92c 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_device.c @@ -1596,7 +1596,11 @@ void anv_GetPhysicalDeviceFeatures2( case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_LINE_RASTERIZATION_FEATURES_EXT: { VkPhysicalDeviceLineRasterizationFeaturesEXT *features = (VkPhysicalDeviceLineRasterizationFeaturesEXT *)ext; - features->rectangularLines = true; + /* Rectangular lines must use the strict algorithm, which is not + * supported for wide lines prior to ICL. See rasterization_mode for + * details and how the HW states are programmed. + */ + features->rectangularLines = pdevice->info.ver >= 10; features->bresenhamLines = true; /* Support for Smooth lines with MSAA was removed on gfx11. From the * BSpec section "Multisample ModesState" table for "AA Line Support -- 2.7.4