From b2ae1c1a85f3df9dcca2b18398483a6bb0f22fdc Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Mon, 15 Jul 2019 20:14:02 -0400 Subject: [PATCH] Remove unnecessary "internal" from JsonConverterFactory ctor (dotnet/corefx#39504) The ctor is already `protected`, so it can already be accessed by any derived type. The only benefit adding `internal` would provide is so that it could be called directly by something else in the assembly, but the type is `abstract`, so that doesn't make sense for a ctor. Commit migrated from https://github.com/dotnet/corefx/commit/902294e7933e84601aa4543fc3afe0dcf85c2d99 --- src/libraries/System.Text.Json/ref/System.Text.Json.cs | 2 +- .../src/System/Text/Json/Serialization/JsonConverterFactory.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.Text.Json/ref/System.Text.Json.cs b/src/libraries/System.Text.Json/ref/System.Text.Json.cs index 82bc52d..b4120e2 100644 --- a/src/libraries/System.Text.Json/ref/System.Text.Json.cs +++ b/src/libraries/System.Text.Json/ref/System.Text.Json.cs @@ -466,7 +466,7 @@ namespace System.Text.Json.Serialization } public abstract partial class JsonConverterFactory : System.Text.Json.Serialization.JsonConverter { - protected internal JsonConverterFactory() { } + protected JsonConverterFactory() { } public abstract System.Text.Json.Serialization.JsonConverter CreateConverter(System.Type typeToConvert, System.Text.Json.JsonSerializerOptions options); } public abstract partial class JsonConverter : System.Text.Json.Serialization.JsonConverter diff --git a/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterFactory.cs b/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterFactory.cs index 5e4d686..35cdd39 100644 --- a/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterFactory.cs +++ b/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterFactory.cs @@ -17,7 +17,7 @@ namespace System.Text.Json.Serialization /// /// When overidden, constructs a new instance. /// - protected internal JsonConverterFactory() { } + protected JsonConverterFactory() { } internal JsonConverter GetConverterInternal(Type typeToConvert, JsonSerializerOptions options) { -- 2.7.4