From b2613744627f88d2d0de1d5b24cb9b1bb416aad7 Mon Sep 17 00:00:00 2001 From: Mohammed Sameer Date: Tue, 8 Apr 2014 20:54:26 +0300 Subject: [PATCH] camerabin: report an error if we fail to link vfsrc and viewfinder queue https://bugzilla.gnome.org/show_bug.cgi?id=727855 --- gst/camerabin2/gstcamerabin2.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gst/camerabin2/gstcamerabin2.c b/gst/camerabin2/gstcamerabin2.c index 29618f2..8e0806f 100644 --- a/gst/camerabin2/gstcamerabin2.c +++ b/gst/camerabin2/gstcamerabin2.c @@ -1749,8 +1749,13 @@ gst_camera_bin_create_elements (GstCameraBin2 * camera) camera->src_capture_notify_id = g_signal_connect (G_OBJECT (camera->src), "notify::ready-for-capture", G_CALLBACK (gst_camera_bin_src_notify_readyforcapture), camera); - gst_element_link_pads (camera->src, "vfsrc", camera->viewfinderbin_queue, - "sink"); + + if (!gst_element_link_pads (camera->src, "vfsrc", + camera->viewfinderbin_queue, "sink")) { + GST_ERROR_OBJECT (camera, + "Failed to link camera source's vfsrc pad to viewfinder queue"); + goto fail; + } if (!gst_element_link_pads (camera->src, "imgsrc", camera->imagebin_capsfilter, "sink")) { -- 2.7.4