From b2490a326c28652b85400da0e1bbff108167d140 Mon Sep 17 00:00:00 2001 From: Vadym Shovkoplias Date: Mon, 4 Dec 2017 11:47:33 +0200 Subject: [PATCH] util/disk_cache: Remove unneeded free() on always null string At this point dc_job->cache_item_metadata.keys always equals NULL, so call to free() is useless Fixes: b86ecea3446 ("util/disk_cache: write cache item metadata to disk") Signed-off-by: Vadym Shovkoplias Reviewed-by: Eric Engestrom --- src/util/disk_cache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index e954065..7ebfa8c 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -811,7 +811,6 @@ create_put_job(struct disk_cache *cache, const cache_key key, return dc_job; fail: - free(dc_job->cache_item_metadata.keys); free(dc_job); return NULL; -- 2.7.4