From b226553298c71494e938271013c62fedb0ad49d0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Vladimir=20Plazun/AI=20Tools=20Lab/Engineer/=EC=82=BC?= =?utf8?q?=EC=84=B1=EC=A0=84=EC=9E=90?= Date: Tue, 5 Jun 2018 19:48:58 +0400 Subject: [PATCH] Fix compiler warnings in operation descriptions (#310) Fixes compiler warnings in PoolOp and OpDescription classes Add missing OpDescription virtual destructor Signed-off-by: Vladimir Plazun --- .../nnc/libs/core/include/nnc/core/IR/model/operations/operation.h | 1 + contrib/nnc/libs/core/include/nnc/core/IR/model/operations/pool_op.h | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/nnc/libs/core/include/nnc/core/IR/model/operations/operation.h b/contrib/nnc/libs/core/include/nnc/core/IR/model/operations/operation.h index 7fa9cce..55426bd 100644 --- a/contrib/nnc/libs/core/include/nnc/core/IR/model/operations/operation.h +++ b/contrib/nnc/libs/core/include/nnc/core/IR/model/operations/operation.h @@ -23,6 +23,7 @@ using nncc::contrib::core::ADT::TensorVariant; class OpDescription { public: explicit OpDescription(const size_t max_inputs, const size_t max_outputs); + virtual ~OpDescription() = default; size_t getNumInputs() const; size_t getNumOutputs() const; diff --git a/contrib/nnc/libs/core/include/nnc/core/IR/model/operations/pool_op.h b/contrib/nnc/libs/core/include/nnc/core/IR/model/operations/pool_op.h index 75bcdc1..8e2f242 100644 --- a/contrib/nnc/libs/core/include/nnc/core/IR/model/operations/pool_op.h +++ b/contrib/nnc/libs/core/include/nnc/core/IR/model/operations/pool_op.h @@ -35,8 +35,7 @@ public: explicit PoolOp(const Shape &windowShape, const Shape &strides, PoolingType poolType, PaddingType padding) - : OpDescription(1, 1), _padding(padding), _poolingType(poolType), _strides(strides), - _windowShape(windowShape) + : OpDescription(1, 1), _padding(padding), _poolingType(poolType), _windowShape(windowShape), _strides(strides) { _pads.resize(_windowShape.rank()); } @@ -49,7 +48,7 @@ public: const Shape &getStrides() const { return _strides; } - const int getPadding(int dim) const { return _pads[dim]; } + int getPadding(int dim) const { return _pads[dim]; } void setPadding(int dim, int pad) { _pads[dim] = pad; } -- 2.7.4