From b217ddb1bb8861411d85899b750ac02cbbcafb88 Mon Sep 17 00:00:00 2001 From: Kirill Bobyrev Date: Mon, 27 Aug 2018 09:47:50 +0000 Subject: [PATCH] [clangd] Use TRUE iterator instead of complete posting list Stop using `$$$` (empty) trigram and generating a posting list with all items. Since TRUE iterator is already implemented and correctly inserted when there are no real trigram posting lists, this is a valid transformation. Benchmarks show that this simple change allows ~30% speedup on dataset of real completion queries. Before ``` ------------------------------------------------------- Benchmark Time CPU Iterations ------------------------------------------------------- DexAdHocQueries 5640321 ns 5640265 ns 120 DexRealQ 939835603 ns 939830296 ns 1 ``` After ``` ------------------------------------------------------- Benchmark Time CPU Iterations ------------------------------------------------------- DexAdHocQueries 3452014 ns 3451987 ns 203 DexRealQ 667455912 ns 667455750 ns 1 ``` Reviewed by: ilya-biryukov Differential Revision: https://reviews.llvm.org/D51287 llvm-svn: 340729 --- clang-tools-extra/clangd/index/dex/Trigram.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/clang-tools-extra/clangd/index/dex/Trigram.cpp b/clang-tools-extra/clangd/index/dex/Trigram.cpp index af422ea..25a14ff 100644 --- a/clang-tools-extra/clangd/index/dex/Trigram.cpp +++ b/clang-tools-extra/clangd/index/dex/Trigram.cpp @@ -67,10 +67,6 @@ std::vector generateIdentifierTrigrams(llvm::StringRef Identifier) { UniqueTrigrams.insert(Token(Token::Kind::Trigram, Chars)); }; - // FIXME(kbobyrev): Instead of producing empty trigram for each identifier, - // just use True Iterator on the query side when the query string is empty. - add({{END_MARKER, END_MARKER, END_MARKER}}); - if (TwoHeads.size() == 2) add({{TwoHeads.front(), TwoHeads.back(), END_MARKER}}); -- 2.7.4