From b1751ae3cb5c9330c4ed8a2a66e2e85a144894d2 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Sun, 4 Feb 2007 14:11:51 +0000 Subject: [PATCH] tests/check/libs/utils.c: Fix unit test. Turns out things work much better when you Original commit message from CVS: * tests/check/libs/utils.c: (GST_START_TEST): Fix unit test. Turns out things work much better when you NULL-terminate string arrays. Should make p5 build bot happy again. --- ChangeLog | 6 ++++++ tests/check/libs/pbutils.c | 14 ++++++-------- tests/check/libs/utils.c | 14 ++++++-------- 3 files changed, 18 insertions(+), 16 deletions(-) diff --git a/ChangeLog b/ChangeLog index a75568d45..498da3298 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2007-02-04 Tim-Philipp Müller + + * tests/check/libs/utils.c: (GST_START_TEST): + Fix unit test. Turns out things work much better when you + NULL-terminate string arrays. Should make p5 build bot happy again. + 2007-02-03 Tim-Philipp Müller * gst-libs/gst/audio/Makefile.am: diff --git a/tests/check/libs/pbutils.c b/tests/check/libs/pbutils.c index a90725c52..81105dbcd 100644 --- a/tests/check/libs/pbutils.c +++ b/tests/check/libs/pbutils.c @@ -72,7 +72,8 @@ GST_START_TEST (test_base_utils_post_missing_messages) bus = gst_element_get_bus (pipeline); /* first, test common assertion failure cases */ - ASSERT_CRITICAL (msg = gst_missing_uri_source_message_new (NULL, "http");); + ASSERT_CRITICAL (msg = gst_missing_uri_source_message_new (NULL, "http"); + ); ASSERT_CRITICAL (gst_missing_uri_source_message_new (pipeline, NULL)); ASSERT_CRITICAL (gst_missing_uri_sink_message_new (NULL, "http")); @@ -536,18 +537,15 @@ GST_START_TEST (test_base_utils_install_plugins) { GstInstallPluginsContext *ctx; GstInstallPluginsReturn ret; - gchar *details[] = { "detail1", "detail2" }; + gchar *details[] = { "detail1", "detail2", NULL }; ctx = gst_install_plugins_context_new (); - ASSERT_CRITICAL (ret = gst_install_plugins_sync (NULL, ctx); - ); + ASSERT_CRITICAL (ret = gst_install_plugins_sync (NULL, ctx);); ASSERT_CRITICAL (ret = - gst_install_plugins_async (NULL, ctx, result_cb, (gpointer) & marker); - ); + gst_install_plugins_async (NULL, ctx, result_cb, (gpointer) & marker);); ASSERT_CRITICAL (ret = - gst_install_plugins_async (details, ctx, NULL, (gpointer) & marker); - ); + gst_install_plugins_async (details, ctx, NULL, (gpointer) & marker);); /* make sure the functions return the right error code if the helper does * not exist */ diff --git a/tests/check/libs/utils.c b/tests/check/libs/utils.c index a90725c52..81105dbcd 100644 --- a/tests/check/libs/utils.c +++ b/tests/check/libs/utils.c @@ -72,7 +72,8 @@ GST_START_TEST (test_base_utils_post_missing_messages) bus = gst_element_get_bus (pipeline); /* first, test common assertion failure cases */ - ASSERT_CRITICAL (msg = gst_missing_uri_source_message_new (NULL, "http");); + ASSERT_CRITICAL (msg = gst_missing_uri_source_message_new (NULL, "http"); + ); ASSERT_CRITICAL (gst_missing_uri_source_message_new (pipeline, NULL)); ASSERT_CRITICAL (gst_missing_uri_sink_message_new (NULL, "http")); @@ -536,18 +537,15 @@ GST_START_TEST (test_base_utils_install_plugins) { GstInstallPluginsContext *ctx; GstInstallPluginsReturn ret; - gchar *details[] = { "detail1", "detail2" }; + gchar *details[] = { "detail1", "detail2", NULL }; ctx = gst_install_plugins_context_new (); - ASSERT_CRITICAL (ret = gst_install_plugins_sync (NULL, ctx); - ); + ASSERT_CRITICAL (ret = gst_install_plugins_sync (NULL, ctx);); ASSERT_CRITICAL (ret = - gst_install_plugins_async (NULL, ctx, result_cb, (gpointer) & marker); - ); + gst_install_plugins_async (NULL, ctx, result_cb, (gpointer) & marker);); ASSERT_CRITICAL (ret = - gst_install_plugins_async (details, ctx, NULL, (gpointer) & marker); - ); + gst_install_plugins_async (details, ctx, NULL, (gpointer) & marker);); /* make sure the functions return the right error code if the helper does * not exist */ -- 2.34.1