From b129eb0e566d53a2500d505cbb80e8ad4ad6f981 Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Thu, 2 Sep 2010 22:35:18 +0000 Subject: [PATCH] * dwarf.c (init_dwarf_regnames_i386, init_dwarf_regnames_x86_64): New. (init_dwarf_regnames): Use them. * dwarf.h: Declare them. * objdump.c (dump_dwarf): Use bfd_get_arch + bfd_get_mach to set up the regnames, rather than using elf_machine_code. --- binutils/ChangeLog | 10 +++++++++- binutils/dwarf.c | 20 ++++++++++++++++---- binutils/dwarf.h | 2 ++ binutils/objdump.c | 20 +++++++++++++++++--- 4 files changed, 44 insertions(+), 8 deletions(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index ed4030a..c3f1278 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,4 +1,12 @@ -2010-08-23 Richard Henderson +2010-09-02 Richard Henderson + + * dwarf.c (init_dwarf_regnames_i386, init_dwarf_regnames_x86_64): New. + (init_dwarf_regnames): Use them. + * dwarf.h: Declare them. + * objdump.c (dump_dwarf): Use bfd_get_arch + bfd_get_mach to set up + the regnames, rather than using elf_machine_code. + +2010-09-02 Richard Henderson * objdump.c (dump_dwarf): Use bfd_arch_bits_per_address. diff --git a/binutils/dwarf.c b/binutils/dwarf.c index 84e22eb..1d2679b 100644 --- a/binutils/dwarf.c +++ b/binutils/dwarf.c @@ -3961,6 +3961,13 @@ static const char *const dwarf_regnames_i386[] = "tr", "ldtr" }; +void +init_dwarf_regnames_i386 (void) +{ + dwarf_regnames = dwarf_regnames_i386; + dwarf_regnames_count = ARRAY_SIZE (dwarf_regnames_i386); +} + static const char *const dwarf_regnames_x86_64[] = { "rax", "rdx", "rcx", "rbx", @@ -3984,20 +3991,25 @@ static const char *const dwarf_regnames_x86_64[] = }; void +init_dwarf_regnames_x86_64 (void) +{ + dwarf_regnames = dwarf_regnames_x86_64; + dwarf_regnames_count = ARRAY_SIZE (dwarf_regnames_x86_64); +} + +void init_dwarf_regnames (unsigned int e_machine) { switch (e_machine) { case EM_386: case EM_486: - dwarf_regnames = dwarf_regnames_i386; - dwarf_regnames_count = ARRAY_SIZE (dwarf_regnames_i386); + init_dwarf_regnames_i386 (); break; case EM_X86_64: case EM_L1OM: - dwarf_regnames = dwarf_regnames_x86_64; - dwarf_regnames_count = ARRAY_SIZE (dwarf_regnames_x86_64); + init_dwarf_regnames_x86_64 (); break; default: diff --git a/binutils/dwarf.h b/binutils/dwarf.h index 58ecc67..a9b501f 100644 --- a/binutils/dwarf.h +++ b/binutils/dwarf.h @@ -122,6 +122,8 @@ extern int do_trace_aranges; extern int do_wide; extern void init_dwarf_regnames (unsigned int); +extern void init_dwarf_regnames_i386 (void); +extern void init_dwarf_regnames_x86_64 (void); extern int load_debug_section (enum dwarf_section_display_enum, void *); diff --git a/binutils/objdump.c b/binutils/objdump.c index ca7741d..8e7d24d 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -2349,10 +2349,24 @@ dump_dwarf (bfd *abfd) else abort (); - if (bfd_get_flavour (abfd) == bfd_target_elf_flavour) + switch (bfd_get_arch (abfd)) { - const struct elf_backend_data *bed = get_elf_backend_data (abfd); - init_dwarf_regnames (bed->elf_machine_code); + case bfd_arch_i386: + switch (bfd_get_mach (abfd)) + { + case bfd_mach_x86_64: + case bfd_mach_x86_64_intel_syntax: + init_dwarf_regnames_x86_64 (); + break; + + default: + init_dwarf_regnames_i386 (); + break; + } + break; + + default: + break; } bfd_map_over_sections (abfd, dump_dwarf_section, NULL); -- 2.7.4