From b1133c895f8e570265c275b35440c00306ff7a5e Mon Sep 17 00:00:00 2001 From: Ed Bartosh Date: Sat, 27 Jul 2013 00:00:26 +0300 Subject: [PATCH] Implemented silent mode for gerrit review Added silent_mode parameter to Gerrit constructor. If silent_mode is True gerrit review command is not called and review mark is not reported back to Gerrit. job_submitobs gets value of silent mode from GERRIT_SILENT_MODE environment variable. This variable must be set in jobs/configuration file for Jenkins instances, where reporting back to Gerrit is prohibited. Change-Id: I78a57885d3619eee01f48227bb6a299d3b1c8a06 Signed-off-by: Ed Bartosh Reviewed-on: https://otctools.jf.intel.com/review/5651 Tested-by: OTC Tools Tester Reviewed-by: Hasan Wan --- common/gerrit.py | 7 +++++-- job_submitobs.py | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/common/gerrit.py b/common/gerrit.py index 18f535d..7a3c707 100644 --- a/common/gerrit.py +++ b/common/gerrit.py @@ -20,11 +20,13 @@ class GerritError(Exception): class Gerrit: """ Gerrit ssh client command line warper """ - def __init__(self, host, username=getpass.getuser(), port=29418): + def __init__(self, host, username=getpass.getuser(), port=29418, + silent_mode=False): self.host = host self.username = username self.port = port + self.silent_mode = silent_mode if not 'Welcome to Gerrit Code Review' in ''.join(self._cmd_run('')): raise GerritError("Init Error to Gerrit Service host: %s port: %s" @@ -111,7 +113,8 @@ class Gerrit: raise GerritError, \ 'Error: either commit or changeid, patchset is needed' - self._cmd_run('review', args) + if not self.silent_mode: + self._cmd_run('review', args) def get_gerrit_event(): """ get gerrit event info from environment parameters """ diff --git a/job_submitobs.py b/job_submitobs.py index b86fff3..4b94c74 100755 --- a/job_submitobs.py +++ b/job_submitobs.py @@ -298,7 +298,7 @@ def main(): mygit = Git(prjdir) mygerrit = Gerrit(event['hostname'], event['username'], \ - event['sshport']) + event['sshport'], os.getenv('GERRIT_SILENT_MODE')) tag = find_submit_tag(event, mygit) if not tag: -- 2.7.4