From b11303319cd7fe184eaadaf65016f343accb0729 Mon Sep 17 00:00:00 2001 From: Alessandro Decina Date: Wed, 22 Dec 2010 13:56:12 +0100 Subject: [PATCH] encodebin: minor fix in error handling. Don't call gst_bin_remove (bin, ). --- gst/encoding/gstencodebin.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gst/encoding/gstencodebin.c b/gst/encoding/gstencodebin.c index 002ab16..b6e2dc4 100644 --- a/gst/encoding/gstencodebin.c +++ b/gst/encoding/gstencodebin.c @@ -1320,7 +1320,7 @@ static gboolean create_elements_and_pads (GstEncodeBin * ebin) { gboolean ret = TRUE; - GstElement *muxer; + GstElement *muxer = NULL; GstPad *muxerpad; const GList *tmp, *profiles; GstEncodingProfile *sprof; @@ -1400,7 +1400,8 @@ no_muxer_ghost_pad: stream_error: { GST_WARNING ("Could not create Streams"); - gst_bin_remove (GST_BIN (ebin), muxer); + if (muxer) + gst_bin_remove (GST_BIN (ebin), muxer); ebin->muxer = NULL; return FALSE; } -- 2.7.4