From b0950cbea282024a21c735ba20803ac8b05e0b48 Mon Sep 17 00:00:00 2001
From: Fedor Indutny <fedor.indutny@gmail.com>
Date: Mon, 16 Jul 2012 21:41:26 +0400
Subject: [PATCH] net: ignore socket.setTimeout(Infinity) (and NaN)

---
 lib/net.js                         |  2 +-
 test/simple/test-net-settimeout.js | 34 ++++++++++++++++++++--------------
 2 files changed, 21 insertions(+), 15 deletions(-)

diff --git a/lib/net.js b/lib/net.js
index f5d3ebd..b4934e3 100644
--- a/lib/net.js
+++ b/lib/net.js
@@ -160,7 +160,7 @@ Socket.prototype.listen = function() {
 
 
 Socket.prototype.setTimeout = function(msecs, callback) {
-  if (msecs > 0) {
+  if (msecs > 0 && !isNaN(msecs) && isFinite(msecs)) {
     timers.enroll(this, msecs);
     timers.active(this);
     if (callback) {
diff --git a/test/simple/test-net-settimeout.js b/test/simple/test-net-settimeout.js
index 5b14117..da13385 100644
--- a/test/simple/test-net-settimeout.js
+++ b/test/simple/test-net-settimeout.js
@@ -33,18 +33,24 @@ var server = net.createServer(function(c) {
 });
 server.listen(common.PORT);
 
-var socket = net.createConnection(common.PORT, 'localhost');
-
-socket.setTimeout(T, function() {
-  socket.destroy();
-  server.close();
-  assert.ok(false);
+var killers = [0, Infinity, NaN];
+
+var left = killers.length;
+killers.forEach(function(killer) {
+  var socket = net.createConnection(common.PORT, 'localhost');
+
+  socket.setTimeout(T, function() {
+    socket.destroy();
+    if (--left === 0) server.close();
+    assert.ok(killer !== 0);
+    clearTimeout(timeout);
+  });
+
+  socket.setTimeout(killer);
+
+  var timeout = setTimeout(function() {
+    socket.destroy();
+    if (--left === 0) server.close();
+    assert.ok(killer === 0);
+  }, T * 2);
 });
-
-socket.setTimeout(0);
-
-setTimeout(function() {
-  socket.destroy();
-  server.close();
-  assert.ok(true);
-}, T * 2);
-- 
2.7.4