From b07163a296a46f479009d9b72ce85004a7dcacd2 Mon Sep 17 00:00:00 2001
From: Kevron Rees <kevron_m_rees@linux.intel.com>
Date: Fri, 19 Jul 2013 11:48:10 -0700
Subject: [PATCH] fixed package name TIVI-1452

---
 packaging/wrt-plugin-ivi.spec |  6 +++---
 src/Vehicle/Vehicle.cpp       |  4 ++++
 src/Vehicle/Vehicle.idl       | 30 +++++++++++++++++++-----------
 3 files changed, 26 insertions(+), 14 deletions(-)

diff --git a/packaging/wrt-plugin-ivi.spec b/packaging/wrt-plugin-ivi.spec
index 4cc707b..09b49a2 100644
--- a/packaging/wrt-plugin-ivi.spec
+++ b/packaging/wrt-plugin-ivi.spec
@@ -1,4 +1,4 @@
-Name:       wrt-plugin-ivi
+Name:       wrt-plugins-ivi
 Summary:    JavaScript plugins for WebRuntime for IVI
 Version:    0.2.0
 Release:    1
@@ -34,12 +34,12 @@ BuildRequires:  pkgconfig(json-glib-1.0)
 JavaScript plugins for WebRuntime
 
 %package devel
-Summary:    Wrt-plugin-tizen development headers
+Summary:    Wrt-plugins-ivi development headers
 Group:      Development/Libraries
 Requires:   %{name} = %{version}
 
 %description devel
-Wrt-plugin-tizen development headers
+Wrt-plugins-ivi development headers
 
 %prep
 %setup -q
diff --git a/src/Vehicle/Vehicle.cpp b/src/Vehicle/Vehicle.cpp
index 54393b9..783d4cb 100644
--- a/src/Vehicle/Vehicle.cpp
+++ b/src/Vehicle/Vehicle.cpp
@@ -139,6 +139,9 @@ void VehicleMaster::subscribe(std::string objectName, JSObjectRef successCallbac
 		if(objectPath == "")
 		{
 			LoggerE("Error findProperty failed for " <<objectName);
+			
+			///TODO: call error callback with unsupported error
+			
 			return;
 			
 		}
@@ -158,6 +161,7 @@ void VehicleMaster::subscribe(std::string objectName, JSObjectRef successCallbac
 		if(error)
 		{
 			LoggerD("failed to call GetAll on interface " << interfaceName);
+			///TODO: call error callback
 			return;
 		}
 
diff --git a/src/Vehicle/Vehicle.idl b/src/Vehicle/Vehicle.idl
index c5f0043..42c4b99 100644
--- a/src/Vehicle/Vehicle.idl
+++ b/src/Vehicle/Vehicle.idl
@@ -56,25 +56,33 @@ interface Vehicle  {
 	/**  
 	 *  \brief returns supported properties  
 	 *  \arg VehiclePropertyCallback successCallback function to be called when method has completed successfully  
-     *  \arg VehiclePropertyErrorCallback errorCallback this function is called when an error has occured.
-	**/
-    getSupported(SupportedPropertiesCallback successCallback, optional VehiclePropertyErrorCallback errorCallback);
+	 *  \arg VehiclePropertyErrorCallback errorCallback this function is called when an error has occured.
+	 **/
+	getSupported(SupportedPropertiesCallback successCallback, optional VehiclePropertyErrorCallback errorCallback);
+
 	/**  
 	 *  \brief fetch the current value for 'property'.  
-     *  \arg DOMString property is the requested property to be retrieved.
-	 *  \arg VehiclePropertyCallback successCallback function to be called when method has completed successfully  
-     *  \arg VehiclePropertyErrorCallback errorCallback this function is called when an error has occured.
-	**/
-	get(DOMString property, VehiclePropertyCallback successCallback, optional VehiclePropertyErrorCallback errorCallback);  
+	 *  \arg DOMString property is the requested property to be retrieved.
+	 *  \returns object representing the requested 'property'
+	 **/
+	any get(DOMString property);  
+
+	/** \brief subscribe to the given property and get callbacks when it changes
+	 *  \arg DOMString property property to set      
+         *  \arg VehiclePropertyCallback successCallback callback if operation is successfull   
+         *  \arg VehiclePropertyErrorCallback errorCallback callback if error has been called.
+	 **/
+
+	subscribe(DOMString property, VehiclePropertyCallback successCallback, optional VehiclePropertyErrorCallback errorCallback);
 	
 	/**  
 	 *  \brief set the given property to value  
 	 *  \arg DOMString property property to set  
 	 *  \arg VehiclePropertyType value value to set  
-     *  \arg VehiclePropertyCallback successCallback callback if operation is successfull
+	 *  \arg VehiclePropertyCallback successCallback callback if operation is successfull
 	 *  \arg VehiclePropertyErrorCallback errorCallback callback if error has been called.  
-	**/
-    set(DOMString property, VehiclePropertyType value, optional VehiclePropertyCallback successCallback, optional VehiclePropertyErrorCallback errorCallback);
+	 **/
+	set(DOMString property, VehiclePropertyType value, optional VehiclePropertyCallback successCallback, optional VehiclePropertyErrorCallback errorCallback);
         
 	/**  
 	 *  \brief get values for a given property within a certain past time period between 'startTime' and 'endTime'  
-- 
2.7.4