From b0607b71271b75098176e9f630a831bb4235a7c2 Mon Sep 17 00:00:00 2001 From: "erik.corry@gmail.com" Date: Tue, 24 Jan 2012 13:07:21 +0000 Subject: [PATCH] Fix bug 542, misleading documentation of v8::Locker. Review URL: https://chromiumcodereview.appspot.com/9160028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10488 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- include/v8.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/v8.h b/include/v8.h index 294b14d38..2f4772ab7 100644 --- a/include/v8.h +++ b/include/v8.h @@ -2717,7 +2717,7 @@ class RetainedObjectInfo; * default isolate is implicitly created and entered. The embedder * can create additional isolates and use them in parallel in multiple * threads. An isolate can be entered by at most one thread at any - * given time. The Locker/Unlocker API can be used to synchronize. + * given time. The Locker/Unlocker API must be used to synchronize. */ class V8EXPORT Isolate { public: @@ -3559,7 +3559,9 @@ class V8EXPORT Context { * accessing handles or holding onto object pointers obtained * from V8 handles while in the particular V8 isolate. It is up * to the user of V8 to ensure (perhaps with locking) that this - * constraint is not violated. + * constraint is not violated. In addition to any other synchronization + * mechanism that may be used, the v8::Locker and v8::Unlocker classes + * must be used to signal thead switches to V8. * * v8::Locker is a scoped lock object. While it's * active (i.e. between its construction and destruction) the current thread is -- 2.34.1