From b05efe069ace397b0740f0bbedb393d19598cd73 Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Fri, 19 Jul 2019 00:36:19 -0700 Subject: [PATCH] Fix typo: `_TARGET_X86` -> `_TARGET_X86_` (#25788) This typo was in #24989 so would be a new regression in 3.0. In an x86 build, it causes us to not get the cache size correct, leading us to use a smaller default cache size and do more GCs. Tested with GCPerfSim and this PR reduces TotalNumberGCs by 33% using an x86 build. --- src/vm/util.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vm/util.cpp b/src/vm/util.cpp index da6d779..c8b9e9a 100644 --- a/src/vm/util.cpp +++ b/src/vm/util.cpp @@ -1817,7 +1817,7 @@ size_t GetCacheSizePerLogicalCpu(BOOL bTrueSize) maxSize = maxTrueSize = GetLogicalProcessorCacheSizeFromOS() ; // Returns the size of the highest level processor cache #endif -#if defined (_TARGET_X86) || defined(_TARGET_AMD64_) +#if defined (_TARGET_X86_) || defined(_TARGET_AMD64_) if (maxSize == 0) { maxSize = maxTrueSize = GetCacheSizeFromCpuId(); -- 2.7.4