From b05a7851095c24ff62d5ffeb81baeffe7acd26a2 Mon Sep 17 00:00:00 2001 From: Al Viro Date: Thu, 8 Oct 2015 20:18:00 -0400 Subject: [PATCH] orangefs: double iput() in case of d_make_root() failure Signed-off-by: Al Viro Signed-off-by: Mike Marshall --- fs/orangefs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c index 9dee952..833af68 100644 --- a/fs/orangefs/super.c +++ b/fs/orangefs/super.c @@ -403,10 +403,8 @@ static int pvfs2_fill_sb(struct super_block *sb, void *data, int silent) /* allocates and places root dentry in dcache */ root_dentry = d_make_root(root); - if (!root_dentry) { - iput(root); + if (!root_dentry) return -ENOMEM; - } sb->s_export_op = &pvfs2_export_ops; sb->s_root = root_dentry; -- 2.7.4