From afe9facc9f7c70ed8a9097ed660bd0bdd31ed14b Mon Sep 17 00:00:00 2001 From: mtklein Date: Mon, 22 Feb 2016 14:59:59 -0800 Subject: [PATCH] Run no CPU benches in Debug trybots. They seem to just be wasting time on the CQ. Hacking this into nanobench_flags.py makes it easy to back out. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720223002 Review URL: https://codereview.chromium.org/1720223002 --- tools/nanobench_flags.json | 17 +++++++++++++++++ tools/nanobench_flags.py | 5 +++++ 2 files changed, 22 insertions(+) diff --git a/tools/nanobench_flags.json b/tools/nanobench_flags.json index c80ced8..2eaa3b7 100644 --- a/tools/nanobench_flags.json +++ b/tools/nanobench_flags.json @@ -167,6 +167,23 @@ "~inc0.webp", "~inc1.webp" ], + "Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot": [ + "--pre_log", + "--scales", + "1.0", + "1.1", + "--config", + "565", + "8888", + "gpu", + "nonrendering", + "angle", + "hwui", + "msaa16", + "nvprmsaa16", + "--match", + "nothing_will_match_this" + ], "Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind": [ "--pre_log", "--images", diff --git a/tools/nanobench_flags.py b/tools/nanobench_flags.py index 50d5feb..451cd55 100755 --- a/tools/nanobench_flags.py +++ b/tools/nanobench_flags.py @@ -120,6 +120,10 @@ def get_args(bot): match.append('~inc0.webp') match.append('~inc1.webp') + # As an experiment, skip nanobench on Debug trybots. + if 'Debug' in bot and 'CPU' in bot and 'Trybot' in bot: + match = ['nothing_will_match_this'] + if match: args.append('--match') args.extend(match) @@ -139,6 +143,7 @@ def self_test(): 'Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Debug-ANGLE', 'Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug', 'Test-Android-GCC-GalaxyS4-GPU-SGX544-Arm7-Release', + 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot', ] cov = coverage.coverage() -- 2.7.4