From aefa11166f203386017f0eff36f7392bc0c2fa23 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Martin=20Storsj=C3=B6?= Date: Fri, 10 Jun 2022 10:57:40 +0300 Subject: [PATCH] [LLD] [MinGW] Implement --disable-reloc-section, mapped to /fixed Since binutils 2.36, GNU ld defaults to emitting base relocations, and that version added the new option --disable-reloc-section to disable it. Differential Revision: https://reviews.llvm.org/D127478 --- lld/MinGW/Driver.cpp | 3 +++ lld/MinGW/Options.td | 7 +++++++ lld/test/MinGW/driver.test | 7 +++++++ 3 files changed, 17 insertions(+) diff --git a/lld/MinGW/Driver.cpp b/lld/MinGW/Driver.cpp index 93a2664..5920a50 100644 --- a/lld/MinGW/Driver.cpp +++ b/lld/MinGW/Driver.cpp @@ -323,6 +323,9 @@ bool mingw::link(ArrayRef argsArr, llvm::raw_ostream &stdoutOS, if (args.hasFlag(OPT_disable_tsaware, OPT_tsaware, false)) add("-tsaware:no"); + if (args.hasFlag(OPT_disable_reloc_section, OPT_enable_reloc_section, false)) + add("-fixed"); + if (args.hasFlag(OPT_no_insert_timestamp, OPT_insert_timestamp, false)) add("-timestamp:0"); diff --git a/lld/MinGW/Options.td b/lld/MinGW/Options.td index b96449f..bfdd4af 100644 --- a/lld/MinGW/Options.td +++ b/lld/MinGW/Options.td @@ -31,6 +31,11 @@ multiclass B_disable { def disable_ # NAME: Flag<["--", "-"], "disable-" # name>, HelpText; } +multiclass B_enable_disable { + def enable_ # NAME: Flag<["--", "-"], "enable-" # name>, HelpText; + def disable_ # NAME: Flag<["--", "-"], "disable-" # name>, HelpText; +} + def L: JoinedOrSeparate<["-"], "L">, MetaVarName<"">, HelpText<"Add a directory to the library search path">; defm allow_multiple_definition: B<"allow-multiple-definition", @@ -98,6 +103,8 @@ def o: JoinedOrSeparate<["-"], "o">, MetaVarName<"">, HelpText<"Path to file to write output">; defm out_implib: Eq<"out-implib", "Import library name">; defm output_def: Eq<"output-def", "Output def file">; +defm reloc_section: B_enable_disable<"reloc-section", + "Enable base relocations", "Disable base relocations">; defm section_alignment: Eq<"section-alignment", "Set section alignment">; def shared: F<"shared">, HelpText<"Build a shared object">; defm subs: Eq<"subsystem", "Specify subsystem">; diff --git a/lld/test/MinGW/driver.test b/lld/test/MinGW/driver.test index e8b00ae..c67717d 100644 --- a/lld/test/MinGW/driver.test +++ b/lld/test/MinGW/driver.test @@ -181,6 +181,13 @@ RUN: ld.lld -### -m i386pe foo.o -disable-tsaware -tsaware 2>&1 | FileCheck -che RUN: ld.lld -### -m i386pe foo.o --disable-tsaware --tsaware 2>&1 | FileCheck -check-prefix NO-DISABLE-TSAWARE %s NO-DISABLE-TSAWARE-NOT: -tsaware:no +RUN: ld.lld -### -m i386pe foo.o -enable-reloc-section -disable-reloc-section 2>&1 | FileCheck -check-prefix DISABLE-RELOC-SECTION %s +RUN: ld.lld -### -m i386pe foo.o --enable-reloc-section --disable-reloc-section 2>&1 | FileCheck -check-prefix DISABLE-RELOC-SECTION %s +DISABLE-RELOC-SECTION: -fixed{{ }} +RUN: ld.lld -### -m i386pe foo.o -disable-reloc-section -enable-reloc-section 2>&1 | FileCheck -check-prefix NO-DISABLE-RELOC-SECTION %s +RUN: ld.lld -### -m i386pe foo.o --disable-reloc-section --enable-reloc-section 2>&1 | FileCheck -check-prefix NO-DISABLE-RELOC-SECTION %s +NO-DISABLE-RELOC-SECTION-NOT: -fixed + RUN: ld.lld -### -m i386pep foo.o --image-base 0x1230000 2>&1 | FileCheck -check-prefix IMAGE-BASE %s RUN: ld.lld -### -m i386pep foo.o -image-base 0x1230000 2>&1 | FileCheck -check-prefix IMAGE-BASE %s RUN: ld.lld -### -m i386pep foo.o --image-base=0x1230000 2>&1 | FileCheck -check-prefix IMAGE-BASE %s -- 2.7.4