From aedfd3bf0ebbf5de5bc03c83f54c9b8f98b28515 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Tue, 15 Dec 2015 16:44:38 -0800 Subject: [PATCH] Add specs for companyName/submitURL being required --- atom/common/api/lib/deprecate.coffee | 3 +-- spec/api-crash-reporter-spec.coffee | 9 ++++++++- spec/static/main.js | 3 +++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/atom/common/api/lib/deprecate.coffee b/atom/common/api/lib/deprecate.coffee index a7de926..2481790 100644 --- a/atom/common/api/lib/deprecate.coffee +++ b/atom/common/api/lib/deprecate.coffee @@ -52,7 +52,7 @@ deprecate.event = (emitter, oldName, newName, fn) -> else @emit oldName, args... -# Print deprecate warning. +# Print deprecation warning. deprecate.warn = (oldName, newName) -> deprecate.log("#{oldName} is deprecated. Use #{newName} instead.") @@ -65,5 +65,4 @@ deprecate.log = (message) -> else console.warn "(electron) #{message}" - module.exports = deprecate diff --git a/spec/api-crash-reporter-spec.coffee b/spec/api-crash-reporter-spec.coffee index 789ba6e..71b7d1d 100644 --- a/spec/api-crash-reporter-spec.coffee +++ b/spec/api-crash-reporter-spec.coffee @@ -55,5 +55,12 @@ describe 'crash-reporter module', -> pathname: path.join fixtures, 'api', 'crash.html' search: "?port=#{port}" if process.platform is 'darwin' - crashReporter.start {'submitURL': 'http://127.0.0.1:' + port} + crashReporter.start + companyName: 'Umbrella Corporation' + submitURL: "http://127.0.0.1:#{port}" w.loadURL url + + describe ".start(options)", -> + it 'requires that the companyName and submitURL option fields be specified', -> + assert.throws(-> crashReporter.start({companyName: 'Missing submitURL'})) + assert.throws(-> crashReporter.start({submitURL: 'Missing companyName'})) diff --git a/spec/static/main.js b/spec/static/main.js index 4de1238..35ae544 100644 --- a/spec/static/main.js +++ b/spec/static/main.js @@ -4,6 +4,9 @@ const ipcMain = electron.ipcMain; const dialog = electron.dialog; const BrowserWindow = electron.BrowserWindow; +// Disable use of deprecated functions. +process.throwDeprecation = true; + const path = require('path'); const url = require('url'); -- 2.7.4