From aeac974b8361e9f92684a0f7cb7e38f4763bb7f1 Mon Sep 17 00:00:00 2001 From: Simon Hausmann Date: Tue, 13 Aug 2013 12:00:39 +0200 Subject: [PATCH] Improve reliability of v4 debugger tests Sometimes the test hangs on shutdown. Don't wait for the finished signal to be emitted with an event loop, instead do the QThread equivalent of pthread_join: wait(). Change-Id: I3583e8366c08fc0446682d124d86df4ffa3290d3 Reviewed-by: Lars Knoll --- tests/auto/qml/qv4debugger/tst_qv4debugger.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/auto/qml/qv4debugger/tst_qv4debugger.cpp b/tests/auto/qml/qv4debugger/tst_qv4debugger.cpp index c6ecd19..7d8f02a 100644 --- a/tests/auto/qml/qv4debugger/tst_qv4debugger.cpp +++ b/tests/auto/qml/qv4debugger/tst_qv4debugger.cpp @@ -176,7 +176,7 @@ void tst_qv4debugger::init() void tst_qv4debugger::cleanup() { m_javaScriptThread->exit(); - waitForSignal(m_javaScriptThread, SIGNAL(finished()), /*timeout*/ 0); + m_javaScriptThread->wait(); delete m_engine; delete m_javaScriptThread; m_engine = 0; -- 2.7.4