From ae9c48087f50f2373e62dc2e0fb63178e256f351 Mon Sep 17 00:00:00 2001 From: Maximilian Weigand Date: Wed, 10 May 2023 10:52:39 +0200 Subject: [PATCH] backlight: lm3630a: Turn off both led strings when display is blank Use backlight_is_blank() to determine if the led strings should be turned off in the update_status() functions of both strings. Signed-off-by: Maximilian Weigand Reviewed-by: Daniel Thompson Reviewed-by: Sam Ravnborg Link: https://lore.kernel.org/r/20230510085239.1253896-1-mweigand2017@gmail.com Signed-off-by: Lee Jones --- drivers/video/backlight/lm3630a_bl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index d8c42ac..faf92c8 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -202,7 +202,9 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl) usleep_range(1000, 2000); /* minimum brightness is 0x04 */ ret = lm3630a_write(pchip, REG_BRT_A, bl->props.brightness); - if (bl->props.brightness < 0x4) + + if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4)) + /* turn the string off */ ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDA_ENABLE, 0); else ret |= lm3630a_update(pchip, REG_CTRL, @@ -277,7 +279,9 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl) usleep_range(1000, 2000); /* minimum brightness is 0x04 */ ret = lm3630a_write(pchip, REG_BRT_B, bl->props.brightness); - if (bl->props.brightness < 0x4) + + if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4)) + /* turn the string off */ ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDB_ENABLE, 0); else ret |= lm3630a_update(pchip, REG_CTRL, -- 2.7.4