From ae848d746b8a34abae279d56accd047677e292ff Mon Sep 17 00:00:00 2001 From: "zheng.zixiang" Date: Wed, 2 Nov 2011 18:19:02 +0800 Subject: [PATCH] [PORT FROM R2] atomisp: Address Klocwork critical issue in drivers BZ: 17272 Fix Klocwork critical issue that index of 'sh_css_blob_info' may be out of bounds. Signed-off-by: zheng.zixiang Change-Id: Ib80656441fd1f5d18cc93dc9560e95b6ef70bed2 Orig-Change-Id: I71c9e1becc8d82d2f058002c1fe65630848de73c Signed-off-by: zheng.zixiang Signed-off-by: ziyux.jiang Reviewed-on: http://android.intel.com:8080/22951 Reviewed-by: Koski, Anttu Reviewed-by: Cohen, David A Reviewed-by: Koskinen, Ilkka Reviewed-by: Kruger, Jozef Reviewed-by: Zhang, Xiaolin Reviewed-by: Wang, Wen W Tested-by: Koski, Anttu Reviewed-by: buildbot Tested-by: buildbot Reviewed-on: http://android.intel.com:8080/27992 Reviewed-by: Tuominen, TeemuX --- drivers/media/video/atomisp/css/sh_css_binary.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/video/atomisp/css/sh_css_binary.c b/drivers/media/video/atomisp/css/sh_css_binary.c index 9cee7fd..fc8c040 100644 --- a/drivers/media/video/atomisp/css/sh_css_binary.c +++ b/drivers/media/video/atomisp/css/sh_css_binary.c @@ -203,7 +203,7 @@ init_binary_info(struct sh_css_binary_info *info, bool *binary_found) _init_binary_info(info, ISP_VIDEO_DS_); break; default: - break; + return sh_css_err_invalid_arguments; } info->s3atbl_use_dmem = _S3ATBL_USE_DMEM(info->min_output_width != info->max_output_width); -- 2.7.4