From ae74252341a0e985a3b637c9b6c30aed9b6f033b Mon Sep 17 00:00:00 2001
From: Richard Barton <richard.barton@arm.com>
Date: Fri, 26 Jun 2020 18:50:46 +0100
Subject: [PATCH] [flang] Port test_any.sh tests to FileCheck: Hand port
 canondo{08-18} tests

These tests checked for stdout and stderr in the same pipe, which does not
come out in a guaranteed order. test_any.sh's FileCheck accepts CHECK lines in
any order while FileCheck checks must match in order.

Hand port these to pipe stdout to a temp file which is checked with a separate
FileCheck RUN line to test it.

Differential Revision: https://reviews.llvm.org/D82167
---
 flang/test/Semantics/canondo08.f90 | 6 +++---
 flang/test/Semantics/canondo09.f90 | 8 ++++----
 flang/test/Semantics/canondo10.f90 | 8 ++++----
 flang/test/Semantics/canondo11.f90 | 8 ++++----
 flang/test/Semantics/canondo12.f90 | 8 ++++----
 flang/test/Semantics/canondo13.f90 | 8 ++++----
 flang/test/Semantics/canondo14.f90 | 8 ++++----
 flang/test/Semantics/canondo15.f90 | 8 ++++----
 flang/test/Semantics/canondo16.f90 | 8 ++++----
 flang/test/Semantics/canondo17.f90 | 8 ++++----
 flang/test/Semantics/canondo18.f90 | 8 ++++----
 11 files changed, 43 insertions(+), 43 deletions(-)

diff --git a/flang/test/Semantics/canondo08.f90 b/flang/test/Semantics/canondo08.f90
index 465982f..09a277b 100644
--- a/flang/test/Semantics/canondo08.f90
+++ b/flang/test/Semantics/canondo08.f90
@@ -1,4 +1,3 @@
-! RUN: %S/test_any.sh %s %t %f18
 ! Error test -- DO loop uses obsolete loop termination statement
 ! See R1131 and C1133
 
@@ -6,7 +5,7 @@
 ! A warning is generated with -Mstandard
 
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -15,7 +14,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo1()
   do 01 k=1,2
diff --git a/flang/test/Semantics/canondo09.f90 b/flang/test/Semantics/canondo09.f90
index 6c76ac2..6d9efd9 100644
--- a/flang/test/Semantics/canondo09.f90
+++ b/flang/test/Semantics/canondo09.f90
@@ -1,12 +1,11 @@
-! RUN: %S/test_any.sh %s %t %f18
-! Error test -- DO loop uses obsolete loop termination statement
+! Error test -- DO loop uses obsolete loop termination statement (warning)
 ! See R1131 and C1133
 
 ! By default, this is not an error and label do are rewritten to non-label do.
 ! A warning is generated with -Mstandard
 
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -15,7 +14,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo0()
   do  01 j=1,2
diff --git a/flang/test/Semantics/canondo10.f90 b/flang/test/Semantics/canondo10.f90
index adb6582..2733db6f7 100644
--- a/flang/test/Semantics/canondo10.f90
+++ b/flang/test/Semantics/canondo10.f90
@@ -1,12 +1,11 @@
-! RUN: %S/test_any.sh %s %t %f18
-! Error test -- DO loop uses obsolete loop termination statement
+! Error test -- DO loop uses obsolete loop termination statement (warning)
 ! See R1131 and C1133
 
 ! By default, this is not an error and label do are rewritten to non-label do.
 ! A warning is generated with -Mstandard
 
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -15,7 +14,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo2()
   do 01 l=1,2
diff --git a/flang/test/Semantics/canondo11.f90 b/flang/test/Semantics/canondo11.f90
index 2ff61eb..267e76a 100644
--- a/flang/test/Semantics/canondo11.f90
+++ b/flang/test/Semantics/canondo11.f90
@@ -1,12 +1,11 @@
-! RUN: %S/test_any.sh %s %t %f18
-! Error test -- DO loop uses obsolete loop termination statement
+! Error test -- DO loop uses obsolete loop termination statement (warning)
 ! See R1131 and C1133
 
 ! By default, this is not an error and label do are rewritten to non-label do.
 ! A warning is generated with -Mstandard
 
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -15,7 +14,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo3()
   real :: a(10, 10), b(10, 10) = 1.0
diff --git a/flang/test/Semantics/canondo12.f90 b/flang/test/Semantics/canondo12.f90
index bbc7348..b3bc10c 100644
--- a/flang/test/Semantics/canondo12.f90
+++ b/flang/test/Semantics/canondo12.f90
@@ -1,11 +1,10 @@
-! RUN: %S/test_any.sh %s %t %f18
-! Error test -- DO loop uses obsolete loop termination statement
+! Error test -- DO loop uses obsolete loop termination statement (warning)
 ! See R1131 and C1133
 
 ! By default, this is not an error and label do are rewritten to non-label do.
 ! A warning is generated with -Mstandard
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -14,7 +13,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo4()
   real :: a(10, 10), b(10, 10) = 1.0
diff --git a/flang/test/Semantics/canondo13.f90 b/flang/test/Semantics/canondo13.f90
index a127846..d75d8b9 100644
--- a/flang/test/Semantics/canondo13.f90
+++ b/flang/test/Semantics/canondo13.f90
@@ -1,11 +1,10 @@
-! RUN: %S/test_any.sh %s %t %f18
-! Error test -- DO loop uses obsolete loop termination statement
+! Error test -- DO loop uses obsolete loop termination statement (warning)
 ! See R1131 and C1133
 
 ! By default, this is not an error and label do are rewritten to non-label do.
 ! A warning is generated with -Mstandard
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -14,7 +13,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo5()
   real :: a(10, 10), b(10, 10) = 1.0
diff --git a/flang/test/Semantics/canondo14.f90 b/flang/test/Semantics/canondo14.f90
index c504468..99a3d25 100644
--- a/flang/test/Semantics/canondo14.f90
+++ b/flang/test/Semantics/canondo14.f90
@@ -1,11 +1,10 @@
-! RUN: %S/test_any.sh %s %t %f18
-! Error test -- DO loop uses obsolete loop termination statement
+! Error test -- DO loop uses obsolete loop termination statement (warning)
 ! See R1131 and C1133
 
 ! By default, this is not an error and label do are rewritten to non-label do.
 ! A warning is generated with -Mstandard
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -14,7 +13,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo6(a)
   type whatever
diff --git a/flang/test/Semantics/canondo15.f90 b/flang/test/Semantics/canondo15.f90
index 6b52769..059f06c 100644
--- a/flang/test/Semantics/canondo15.f90
+++ b/flang/test/Semantics/canondo15.f90
@@ -1,11 +1,10 @@
-! RUN: %S/test_any.sh %s %t %f18
-! Error test -- DO loop uses obsolete loop termination statement
+! Error test -- DO loop uses obsolete loop termination statement (warning)
 ! See R1131 and C1133
 
 ! By default, this is not an error and label do are rewritten to non-label do.
 ! A warning is generated with -Mstandard
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -14,7 +13,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo7(a)
   integer :: a(..)
diff --git a/flang/test/Semantics/canondo16.f90 b/flang/test/Semantics/canondo16.f90
index a8dfc91..e455fa3 100644
--- a/flang/test/Semantics/canondo16.f90
+++ b/flang/test/Semantics/canondo16.f90
@@ -1,11 +1,10 @@
-! RUN: %S/test_any.sh %s %t %f18
-! Error test -- DO loop uses obsolete loop termination statement
+! Error test -- DO loop uses obsolete loop termination statement (warning)
 ! See R1131 and C1133
 
 ! By default, this is not an error and label do are rewritten to non-label do.
 ! A warning is generated with -Mstandard
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -14,7 +13,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo8()
   use iso_fortran_env, only : team_type
diff --git a/flang/test/Semantics/canondo17.f90 b/flang/test/Semantics/canondo17.f90
index c5e87e2..6edc67c 100644
--- a/flang/test/Semantics/canondo17.f90
+++ b/flang/test/Semantics/canondo17.f90
@@ -1,11 +1,10 @@
-! RUN: %S/test_any.sh %s %t %f18
-! Error test -- DO loop uses obsolete loop termination statement
+! Error test -- DO loop uses obsolete loop termination statement (warning)
 ! See R1131 and C1133
 
 ! By default, this is not an error and label do are rewritten to non-label do.
 ! A warning is generated with -Mstandard
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -14,7 +13,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo9()
   real :: a(10, 10), b(10, 10) = 1.0
diff --git a/flang/test/Semantics/canondo18.f90 b/flang/test/Semantics/canondo18.f90
index d5b18e3..dd9c046 100644
--- a/flang/test/Semantics/canondo18.f90
+++ b/flang/test/Semantics/canondo18.f90
@@ -1,11 +1,10 @@
-! RUN: %S/test_any.sh %s %t %f18
-! Error test -- DO loop uses obsolete loop termination statement
+! Error test -- DO loop uses obsolete loop termination statement (warning)
 ! See R1131 and C1133
 
 ! By default, this is not an error and label do are rewritten to non-label do.
 ! A warning is generated with -Mstandard
 
-! EXEC: ${F18} -funparse-with-symbols -Mstandard %s 2>&1 | ${FileCheck} %s
+! RUN: %f18 -funparse-with-symbols -Mstandard %s 2>%t.stderr | FileCheck %s
 
 ! CHECK: end do
 
@@ -14,7 +13,8 @@
 ! not want to see label do in the unparse only.
 ! CHECK-NOT: do [1-9]
 
-! CHECK: A DO loop should terminate with an END DO or CONTINUE
+! RUN: FileCheck --check-prefix=ERR --input-file=%t.stderr %s
+! ERR: A DO loop should terminate with an END DO or CONTINUE
 
 subroutine foo10()
   real :: a(10, 10), b(10, 10) = 1.0
-- 
2.7.4