From adf80ad1a7a2fbd190e8590e24074da2ad352e4e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Thu, 27 Jan 2022 14:22:26 +0200 Subject: [PATCH] rtphdrext: Return non-floating references from `gst_rtp_header_extension_create_from_uri()` The header extension objects are never getting a parent object and using floating references only complicates usage, especially via dynamic API like signals. Part-of: --- subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtphdrext.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtphdrext.c b/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtphdrext.c index 1116525..48fdd83 100644 --- a/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtphdrext.c +++ b/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtphdrext.c @@ -858,6 +858,8 @@ gst_rtp_header_extension_create_from_uri (const gchar * uri) g_list_free_full (l, (GDestroyNotify) gst_object_unref); + gst_object_ref_sink (element); + return GST_RTP_HEADER_EXTENSION (element); } -- 2.7.4