From adc2ff755db0a78903a9736b9f6eeb918e045a44 Mon Sep 17 00:00:00 2001 From: "ager@chromium.org" Date: Tue, 20 Jul 2010 05:51:10 +0000 Subject: [PATCH] Land for Victor Wang. Add direct_dependent_settings for v8 dll so targets that depend on v8 has USING_V8_SHARED defined. Review URL: http://codereview.chromium.org/2946014/show git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- tools/gyp/v8.gyp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp index 8c7ae37..839ae0b 100644 --- a/tools/gyp/v8.gyp +++ b/tools/gyp/v8.gyp @@ -181,6 +181,11 @@ 'defines': [ 'BUILDING_V8_SHARED' ], + 'direct_dependent_settings': { + 'defines': [ + 'USING_V8_SHARED', + ], + }, }, { 'type': 'none', @@ -738,11 +743,6 @@ # This could be gotten by not setting chromium_code, if that's OK. 'defines': ['_CRT_SECURE_NO_WARNINGS'], }], - ['OS=="win" and component=="shared_library"', { - 'defines': [ - 'USING_V8_SHARED', - ], - }], ], }, ], -- 2.7.4