From ada288ed63561f206ee7cbc0c31d2e43895a3fbb Mon Sep 17 00:00:00 2001 From: Michael Andres Date: Thu, 3 Nov 2011 15:46:35 +0100 Subject: [PATCH] Fix faulty RepoInfo::keepPackages testcase --- tests/zypp/RepoManager_test.cc | 10 +--------- zypp/RepoInfo.h | 2 -- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/tests/zypp/RepoManager_test.cc b/tests/zypp/RepoManager_test.cc index ef225ea..cae630d 100644 --- a/tests/zypp/RepoManager_test.cc +++ b/tests/zypp/RepoManager_test.cc @@ -287,16 +287,8 @@ BOOST_AUTO_TEST_CASE(repo_seting_test) { RepoInfo repo; repo.setAlias("foo"); - repo.addBaseUrl(string("http://test.org")); - BOOST_CHECK_MESSAGE( repo.keepPackages(), "http scheme is not cached"); - repo.setBaseUrl(string("ftp://test.org")); - BOOST_CHECK_MESSAGE( repo.keepPackages(), "ftp scheme is not cached"); - repo.setBaseUrl(string("smb://test.org")); - BOOST_CHECK_MESSAGE( !repo.keepPackages(), "smb scheme is cached"); - repo.setBaseUrl(string("file:///test.txt")); - BOOST_CHECK_MESSAGE( !repo.keepPackages(), "file scheme is cached"); repo.setBaseUrl(string("http://test.org")); - BOOST_CHECK_MESSAGE( repo.keepPackages(), "cache is depend on second url."); + BOOST_CHECK_MESSAGE( !repo.keepPackages(), "keepPackages must default to OFF"); } //! \todo test this diff --git a/zypp/RepoInfo.h b/zypp/RepoInfo.h index 158b9d9..4d98395 100644 --- a/zypp/RepoInfo.h +++ b/zypp/RepoInfo.h @@ -132,7 +132,6 @@ namespace zypp /** * Add a base url. \see baseUrls * \param url The base url for the repository. - * \note can change keepPackages,so change it after this call * * To recreate the base URLs list, use \ref setBaseUrl(const Url &) followed * by addBaseUrl(). @@ -140,7 +139,6 @@ namespace zypp void addBaseUrl( const Url &url ); /** * Clears current base URL list and adds \a url. - * \note can change keepPackages,so change it after this call */ void setBaseUrl( const Url &url ); -- 2.7.4