From ad9268a7b496a794c34b14afa589c58e01307d7b Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Tue, 4 Oct 2016 00:46:36 +0000 Subject: [PATCH] Early return. NFC. llvm-svn: 283173 --- lld/ELF/MarkLive.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lld/ELF/MarkLive.cpp b/lld/ELF/MarkLive.cpp index 4fadd03..d450b30 100644 --- a/lld/ELF/MarkLive.cpp +++ b/lld/ELF/MarkLive.cpp @@ -160,8 +160,8 @@ scanEhFrameSection(EhInputSection &EH, } // We do not garbage-collect two types of sections: -// 1) Sections used by the loader (.init, .fini, .ctors, .dtors, .jcr) -// 2) Not allocatable sections which typically contain debugging information +// 1) Sections used by the loader (.init, .fini, .ctors, .dtors or .jcr) +// 2) Non-allocatable sections which typically contain debugging information template static bool isReserved(InputSectionBase *Sec) { switch (Sec->getSectionHdr()->sh_type) { case SHT_FINI_ARRAY: @@ -170,15 +170,16 @@ template static bool isReserved(InputSectionBase *Sec) { case SHT_PREINIT_ARRAY: return true; default: - StringRef S = Sec->Name; + if (!(Sec->getSectionHdr()->sh_flags & SHF_ALLOC)) + return true; // We do not want to reclaim sections if they can be referred // by __start_* and __stop_* symbols. + StringRef S = Sec->Name; if (isValidCIdentifier(S)) return true; - bool IsAllocSec = Sec->getSectionHdr()->sh_flags & SHF_ALLOC; - return !IsAllocSec || S.startswith(".ctors") || S.startswith(".dtors") || + return S.startswith(".ctors") || S.startswith(".dtors") || S.startswith(".init") || S.startswith(".fini") || S.startswith(".jcr"); } -- 2.7.4