From ad782ce3f7e282a818ad062ba3c18c96b7e742b5 Mon Sep 17 00:00:00 2001 From: Hongbin Zheng Date: Thu, 25 Feb 2016 16:45:46 +0000 Subject: [PATCH] Revert "Introduce DominanceFrontierAnalysis to the new PassManager to compute DominanceFrontier. NFC" This reverts commit 109c38b2226a87b0be73fa7a0a8c1a81df20aeb2. llvm-svn: 261890 --- llvm/include/llvm/Analysis/DominanceFrontier.h | 88 +++++++++++----------- llvm/include/llvm/InitializePasses.h | 2 +- llvm/lib/Analysis/Analysis.cpp | 2 +- llvm/lib/Analysis/DominanceFrontier.cpp | 50 ++++-------- llvm/lib/Analysis/RegionInfo.cpp | 6 +- llvm/lib/CodeGen/MachineFunctionPass.cpp | 2 +- llvm/lib/CodeGen/MachineRegionInfo.cpp | 2 +- llvm/lib/Passes/PassBuilder.cpp | 1 - llvm/lib/Passes/PassRegistry.def | 2 - .../test/Analysis/DominanceFrontier/new_pm_test.ll | 50 ------------ 10 files changed, 68 insertions(+), 137 deletions(-) delete mode 100644 llvm/test/Analysis/DominanceFrontier/new_pm_test.ll diff --git a/llvm/include/llvm/Analysis/DominanceFrontier.h b/llvm/include/llvm/Analysis/DominanceFrontier.h index b4b8a6b..fb73005 100644 --- a/llvm/include/llvm/Analysis/DominanceFrontier.h +++ b/llvm/include/llvm/Analysis/DominanceFrontier.h @@ -24,11 +24,6 @@ namespace llvm { -// FIXME: Replace this brittle forward declaration with the include of the new -// PassManager.h when doing so doesn't break the PassManagerBuilder. -template class AnalysisManager; -class PreservedAnalyses; - //===----------------------------------------------------------------------===// /// DominanceFrontierBase - Common base class for computing forward and inverse /// dominance frontiers for a function. @@ -138,69 +133,78 @@ public: const DomSetType &calculate(const DomTreeT &DT, const DomTreeNodeT *Node); }; -class DominanceFrontier : public ForwardDominanceFrontierBase { +class DominanceFrontier : public FunctionPass { + ForwardDominanceFrontierBase Base; + public: typedef DominatorTreeBase DomTreeT; typedef DomTreeNodeBase DomTreeNodeT; typedef DominanceFrontierBase::DomSetType DomSetType; typedef DominanceFrontierBase::iterator iterator; typedef DominanceFrontierBase::const_iterator const_iterator; -}; -class DominanceFrontierWrapperPass : public FunctionPass { - DominanceFrontier DF; -public: static char ID; // Pass ID, replacement for typeid - DominanceFrontierWrapperPass(); + DominanceFrontier(); - DominanceFrontier &getDominanceFrontier() { return DF; } - const DominanceFrontier &getDominanceFrontier() const { return DF; } + ForwardDominanceFrontierBase &getBase() { return Base; } - void releaseMemory() override; + inline const std::vector &getRoots() const { + return Base.getRoots(); + } - bool runOnFunction(Function &) override; + BasicBlock *getRoot() const { return Base.getRoot(); } - void getAnalysisUsage(AnalysisUsage &AU) const override; + bool isPostDominator() const { return Base.isPostDominator(); } - void print(raw_ostream &OS, const Module * = nullptr) const override; + iterator begin() { return Base.begin(); } - void dump() const; -}; + const_iterator begin() const { return Base.begin(); } -extern template class DominanceFrontierBase; -extern template class ForwardDominanceFrontierBase; + iterator end() { return Base.end(); } -/// \brief Analysis pass which computes a \c DominanceFrontier. -class DominanceFrontierAnalysis { -public: - /// \brief Provide the result typedef for this analysis pass. - typedef DominanceFrontier Result; + const_iterator end() const { return Base.end(); } - /// \brief Opaque, unique identifier for this analysis pass. - static void *ID() { return (void *)&PassID; } + iterator find(BasicBlock *B) { return Base.find(B); } - /// \brief Run the analysis pass over a function and produce a dominator tree. - DominanceFrontier run(Function &F, AnalysisManager *AM); + const_iterator find(BasicBlock *B) const { return Base.find(B); } - /// \brief Provide access to a name for this pass for debugging purposes. - static StringRef name() { return "DominanceFrontierAnalysis"; } + iterator addBasicBlock(BasicBlock *BB, const DomSetType &frontier) { + return Base.addBasicBlock(BB, frontier); + } -private: - static char PassID; -}; + void removeBlock(BasicBlock *BB) { return Base.removeBlock(BB); } + + void addToFrontier(iterator I, BasicBlock *Node) { + return Base.addToFrontier(I, Node); + } -/// \brief Printer pass for the \c DominanceFrontier. -class DominanceFrontierPrinterPass { - raw_ostream &OS; + void removeFromFrontier(iterator I, BasicBlock *Node) { + return Base.removeFromFrontier(I, Node); + } -public: - explicit DominanceFrontierPrinterPass(raw_ostream &OS); - PreservedAnalyses run(Function &F, AnalysisManager *AM); + bool compareDomSet(DomSetType &DS1, const DomSetType &DS2) const { + return Base.compareDomSet(DS1, DS2); + } + + bool compare(DominanceFrontierBase &Other) const { + return Base.compare(Other); + } + + void releaseMemory() override; + + bool runOnFunction(Function &) override; + + void getAnalysisUsage(AnalysisUsage &AU) const override; + + void print(raw_ostream &OS, const Module * = nullptr) const override; - static StringRef name() { return "DominanceFrontierAnalysis"; } + void dump() const; }; +extern template class DominanceFrontierBase; +extern template class ForwardDominanceFrontierBase; + } // End llvm namespace #endif diff --git a/llvm/include/llvm/InitializePasses.h b/llvm/include/llvm/InitializePasses.h index c5fae37..5f2b886 100644 --- a/llvm/include/llvm/InitializePasses.h +++ b/llvm/include/llvm/InitializePasses.h @@ -111,7 +111,7 @@ void initializeDomOnlyPrinterPass(PassRegistry&); void initializeDomOnlyViewerPass(PassRegistry&); void initializeDomPrinterPass(PassRegistry&); void initializeDomViewerPass(PassRegistry&); -void initializeDominanceFrontierWrapperPassPass(PassRegistry&); +void initializeDominanceFrontierPass(PassRegistry&); void initializeDominatorTreeWrapperPassPass(PassRegistry&); void initializeEarlyIfConverterPass(PassRegistry&); void initializeEdgeBundlesPass(PassRegistry&); diff --git a/llvm/lib/Analysis/Analysis.cpp b/llvm/lib/Analysis/Analysis.cpp index b9c97c0..9c53ded 100644 --- a/llvm/lib/Analysis/Analysis.cpp +++ b/llvm/lib/Analysis/Analysis.cpp @@ -38,7 +38,7 @@ void llvm::initializeAnalysis(PassRegistry &Registry) { initializeDelinearizationPass(Registry); initializeDemandedBitsPass(Registry); initializeDivergenceAnalysisPass(Registry); - initializeDominanceFrontierWrapperPassPass(Registry); + initializeDominanceFrontierPass(Registry); initializeDomViewerPass(Registry); initializeDomPrinterPass(Registry); initializeDomOnlyViewerPass(Registry); diff --git a/llvm/lib/Analysis/DominanceFrontier.cpp b/llvm/lib/Analysis/DominanceFrontier.cpp index ef7062d..90e7fd0 100644 --- a/llvm/lib/Analysis/DominanceFrontier.cpp +++ b/llvm/lib/Analysis/DominanceFrontier.cpp @@ -9,7 +9,6 @@ #include "llvm/Analysis/DominanceFrontier.h" #include "llvm/Analysis/DominanceFrontierImpl.h" -#include "llvm/IR/PassManager.h" using namespace llvm; @@ -18,60 +17,41 @@ template class DominanceFrontierBase; template class ForwardDominanceFrontierBase; } -char DominanceFrontierWrapperPass::ID = 0; +char DominanceFrontier::ID = 0; -INITIALIZE_PASS_BEGIN(DominanceFrontierWrapperPass, "domfrontier", +INITIALIZE_PASS_BEGIN(DominanceFrontier, "domfrontier", "Dominance Frontier Construction", true, true) INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass) -INITIALIZE_PASS_END(DominanceFrontierWrapperPass, "domfrontier", +INITIALIZE_PASS_END(DominanceFrontier, "domfrontier", "Dominance Frontier Construction", true, true) - DominanceFrontierWrapperPass::DominanceFrontierWrapperPass() - : FunctionPass(ID), DF() { - initializeDominanceFrontierWrapperPassPass(*PassRegistry::getPassRegistry()); +DominanceFrontier::DominanceFrontier() + : FunctionPass(ID), + Base() { + initializeDominanceFrontierPass(*PassRegistry::getPassRegistry()); } -void DominanceFrontierWrapperPass::releaseMemory() { - DF.releaseMemory(); +void DominanceFrontier::releaseMemory() { + Base.releaseMemory(); } -bool DominanceFrontierWrapperPass::runOnFunction(Function &) { +bool DominanceFrontier::runOnFunction(Function &) { releaseMemory(); - DF.analyze(getAnalysis().getDomTree()); + Base.analyze(getAnalysis().getDomTree()); return false; } -void DominanceFrontierWrapperPass::getAnalysisUsage(AnalysisUsage &AU) const { +void DominanceFrontier::getAnalysisUsage(AnalysisUsage &AU) const { AU.setPreservesAll(); AU.addRequired(); } -void DominanceFrontierWrapperPass::print(raw_ostream &OS, const Module *) const { - DF.print(OS); +void DominanceFrontier::print(raw_ostream &OS, const Module *) const { + Base.print(OS); } #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) -LLVM_DUMP_METHOD void DominanceFrontierWrapperPass::dump() const { +LLVM_DUMP_METHOD void DominanceFrontier::dump() const { print(dbgs()); } #endif - -char DominanceFrontierAnalysis::PassID; - -DominanceFrontier DominanceFrontierAnalysis::run(Function &F, - FunctionAnalysisManager *AM) { - DominanceFrontier DF; - DF.analyze(AM->getResult(F)); - return DF; -} - -DominanceFrontierPrinterPass::DominanceFrontierPrinterPass(raw_ostream &OS) - : OS(OS) {} - -PreservedAnalyses -DominanceFrontierPrinterPass::run(Function &F, FunctionAnalysisManager *AM) { - OS << "DominanceFrontier for function: " << F.getName() << "\n"; - AM->getResult(F).print(OS); - - return PreservedAnalyses::all(); -} diff --git a/llvm/lib/Analysis/RegionInfo.cpp b/llvm/lib/Analysis/RegionInfo.cpp index b4ba5af..dac0cdd 100644 --- a/llvm/lib/Analysis/RegionInfo.cpp +++ b/llvm/lib/Analysis/RegionInfo.cpp @@ -129,7 +129,7 @@ bool RegionInfoPass::runOnFunction(Function &F) { auto DT = &getAnalysis().getDomTree(); auto PDT = &getAnalysis().getPostDomTree(); - auto DF = &getAnalysis().getDominanceFrontier(); + auto DF = &getAnalysis(); RI.recalculate(F, DT, PDT, DF); return false; @@ -146,8 +146,8 @@ void RegionInfoPass::verifyAnalysis() const { void RegionInfoPass::getAnalysisUsage(AnalysisUsage &AU) const { AU.setPreservesAll(); AU.addRequiredTransitive(); + AU.addRequired(); AU.addRequired(); - AU.addRequired(); } void RegionInfoPass::print(raw_ostream &OS, const Module *) const { @@ -165,8 +165,8 @@ char RegionInfoPass::ID = 0; INITIALIZE_PASS_BEGIN(RegionInfoPass, "regions", "Detect single entry single exit regions", true, true) INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass) +INITIALIZE_PASS_DEPENDENCY(DominanceFrontier) INITIALIZE_PASS_DEPENDENCY(PostDominatorTreeWrapperPass) -INITIALIZE_PASS_DEPENDENCY(DominanceFrontierWrapperPass) INITIALIZE_PASS_END(RegionInfoPass, "regions", "Detect single entry single exit regions", true, true) diff --git a/llvm/lib/CodeGen/MachineFunctionPass.cpp b/llvm/lib/CodeGen/MachineFunctionPass.cpp index 5ca41be..05463fc 100644 --- a/llvm/lib/CodeGen/MachineFunctionPass.cpp +++ b/llvm/lib/CodeGen/MachineFunctionPass.cpp @@ -53,7 +53,7 @@ void MachineFunctionPass::getAnalysisUsage(AnalysisUsage &AU) const { // because CodeGen overloads that to mean preserving the MachineBasicBlock // CFG in addition to the LLVM IR CFG. AU.addPreserved(); - AU.addPreserved(); + AU.addPreserved(); AU.addPreserved(); AU.addPreserved(); AU.addPreserved(); diff --git a/llvm/lib/CodeGen/MachineRegionInfo.cpp b/llvm/lib/CodeGen/MachineRegionInfo.cpp index fc32183..0f7ebb3 100644 --- a/llvm/lib/CodeGen/MachineRegionInfo.cpp +++ b/llvm/lib/CodeGen/MachineRegionInfo.cpp @@ -105,7 +105,7 @@ void MachineRegionInfoPass::getAnalysisUsage(AnalysisUsage &AU) const { AU.setPreservesAll(); AU.addRequiredTransitive(); AU.addRequired(); - AU.addRequired(); + AU.addRequired(); } void MachineRegionInfoPass::print(raw_ostream &OS, const Module *) const { diff --git a/llvm/lib/Passes/PassBuilder.cpp b/llvm/lib/Passes/PassBuilder.cpp index 7d0fe7e6..bd30fce 100644 --- a/llvm/lib/Passes/PassBuilder.cpp +++ b/llvm/lib/Passes/PassBuilder.cpp @@ -22,7 +22,6 @@ #include "llvm/Analysis/BasicAliasAnalysis.h" #include "llvm/Analysis/CFLAliasAnalysis.h" #include "llvm/Analysis/CGSCCPassManager.h" -#include "llvm/Analysis/DominanceFrontier.h" #include "llvm/Analysis/LazyCallGraph.h" #include "llvm/Analysis/LoopInfo.h" #include "llvm/Analysis/PostDominators.h" diff --git a/llvm/lib/Passes/PassRegistry.def b/llvm/lib/Passes/PassRegistry.def index 51d9310..ccb4006 100644 --- a/llvm/lib/Passes/PassRegistry.def +++ b/llvm/lib/Passes/PassRegistry.def @@ -58,7 +58,6 @@ FUNCTION_ANALYSIS("aa", AAManager()) FUNCTION_ANALYSIS("assumptions", AssumptionAnalysis()) FUNCTION_ANALYSIS("domtree", DominatorTreeAnalysis()) FUNCTION_ANALYSIS("postdomtree", PostDominatorTreeAnalysis()) -FUNCTION_ANALYSIS("domfrontier", DominanceFrontierAnalysis()) FUNCTION_ANALYSIS("loops", LoopAnalysis()) FUNCTION_ANALYSIS("no-op-function", NoOpFunctionAnalysis()) FUNCTION_ANALYSIS("scalar-evolution", ScalarEvolutionAnalysis()) @@ -92,7 +91,6 @@ FUNCTION_PASS("print", PrintFunctionPass(dbgs())) FUNCTION_PASS("print", AssumptionPrinterPass(dbgs())) FUNCTION_PASS("print", DominatorTreePrinterPass(dbgs())) FUNCTION_PASS("print", PostDominatorTreePrinterPass(dbgs())) -FUNCTION_PASS("print", DominanceFrontierPrinterPass(dbgs())) FUNCTION_PASS("print", LoopPrinterPass(dbgs())) FUNCTION_PASS("print", ScalarEvolutionPrinterPass(dbgs())) FUNCTION_PASS("simplify-cfg", SimplifyCFGPass()) diff --git a/llvm/test/Analysis/DominanceFrontier/new_pm_test.ll b/llvm/test/Analysis/DominanceFrontier/new_pm_test.ll deleted file mode 100644 index 30b2fa6..0000000 --- a/llvm/test/Analysis/DominanceFrontier/new_pm_test.ll +++ /dev/null @@ -1,50 +0,0 @@ -; REQUIRES: asserts -; RUN: opt < %s -passes='print' 2>&1 | FileCheck %s - -define void @a_linear_impl_fig_1() nounwind { -0: - br label %"1" -1: - br label %"2" -2: - br label %"3" -3: - br i1 1, label %"13", label %"4" -4: - br i1 1, label %"5", label %"1" -5: - br i1 1, label %"8", label %"6" -6: - br i1 1, label %"7", label %"4" -7: - ret void -8: - br i1 1, label %"9", label %"1" -9: - br label %"10" -10: - br i1 1, label %"12", label %"11" -11: - br i1 1, label %"9", label %"8" -13: - br i1 1, label %"2", label %"1" -12: - switch i32 0, label %"1" [ i32 0, label %"9" - i32 1, label %"8"] -} - -; CHECK: DominanceFrontier for function: a_linear_impl_fig_1 -; CHECK-DAG: DomFrontier for BB %"0" is: -; CHECK-DAG: DomFrontier for BB %"11" is: %"8" %"9" -; CHECK-DAG: DomFrontier for BB %"1" is: %"1" -; CHECK-DAG: DomFrontier for BB %"2" is: %"1" %"2" -; CHECK-DAG: DomFrontier for BB %"3" is: %"1" %"2" -; CHECK-DAG: DomFrontier for BB %"13" is: %"1" %"2" -; CHECK-DAG: DomFrontier for BB %"4" is: %"1" %"4" -; CHECK-DAG: DomFrontier for BB %"5" is: %"1" %"4" -; CHECK-DAG: DomFrontier for BB %"8" is: %"1" %"8" -; CHECK-DAG: DomFrontier for BB %"6" is: %"4" -; CHECK-DAG: DomFrontier for BB %"7" is: -; CHECK-DAG: DomFrontier for BB %"9" is: %"1" %"8" %"9" -; CHECK-DAG: DomFrontier for BB %"10" is: %"1" %"8" %"9" -; CHECK-DAG: DomFrontier for BB %"12" is: %"1" %"8" %"9" -- 2.7.4