From ad56843dd780711fea6228fb672d7e56af74cb12 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Mon, 6 May 2019 19:50:14 +0000 Subject: [PATCH] [SelectionDAG][X86] Support inline assembly returning an mmx register into a type with fewer than 64 bits. It's possible to use the 'y' mmx constraint with a type narrower than 64-bits. This patch supports this by bitcasting the mmx type to 64-bits and then truncating to the desired type. There are probably other missing type combinations we need to support, but this is the case we have a bug report for. Fixes PR41748. Differential Revision: https://reviews.llvm.org/D61582 llvm-svn: 360069 --- llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | 8 ++++++++ llvm/test/CodeGen/X86/pr41748.ll | 15 +++++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 llvm/test/CodeGen/X86/pr41748.ll diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp index bdb5cab..489bcb4 100644 --- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp @@ -322,6 +322,14 @@ static SDValue getCopyFromParts(SelectionDAG &DAG, const SDLoc &DL, return DAG.getNode(ISD::FP_EXTEND, DL, ValueVT, Val); } + // Handle MMX to a narrower integer type by bitcasting MMX to integer and + // then truncating. + if (PartEVT == MVT::x86mmx && ValueVT.isInteger() && + ValueVT.bitsLT(PartEVT)) { + Val = DAG.getNode(ISD::BITCAST, DL, MVT::i64, Val); + return DAG.getNode(ISD::TRUNCATE, DL, ValueVT, Val); + } + report_fatal_error("Unknown mismatch in getCopyFromParts!"); } diff --git a/llvm/test/CodeGen/X86/pr41748.ll b/llvm/test/CodeGen/X86/pr41748.ll new file mode 100644 index 0000000..c6f213f --- /dev/null +++ b/llvm/test/CodeGen/X86/pr41748.ll @@ -0,0 +1,15 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc < %s -mtriple=x86_64-apple-macosx10.14.0 -mattr=mmx | FileCheck %s + +define i32 @foo(i32 %a) { +; CHECK-LABEL: foo: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: ## InlineAsm Start +; CHECK-NEXT: movd %edi, %mm0 +; CHECK-NEXT: ## InlineAsm End +; CHECK-NEXT: movd %mm0, %eax +; CHECK-NEXT: retq +entry: + %0 = tail call i32 asm sideeffect "movd $1, $0", "=y,r,~{dirflag},~{fpsr},~{flags}"(i32 %a) + ret i32 %0 +} -- 2.7.4