From ad14b9e9ec4973416a911a5d3c59caedc048a279 Mon Sep 17 00:00:00 2001 From: Viresh Kumar Date: Mon, 31 Aug 2015 17:21:08 +0530 Subject: [PATCH] greybus: bundle: kill unnecessary forward declaration of routine Move the function to an earlier place, to kill the unnecessary forward declaration. Reviewed-by: Bryan O'Donoghue Reviewed-by: Johan Hovold Signed-off-by: Viresh Kumar Signed-off-by: Johan Hovold --- drivers/staging/greybus/bundle.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c index 694bcce..459c62a 100644 --- a/drivers/staging/greybus/bundle.c +++ b/drivers/staging/greybus/bundle.c @@ -9,8 +9,6 @@ #include "greybus.h" -static void gb_bundle_connections_exit(struct gb_bundle *bundle); - static ssize_t class_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -197,6 +195,18 @@ struct gb_bundle *gb_bundle_create(struct gb_interface *intf, u8 bundle_id, return bundle; } +static void gb_bundle_connections_exit(struct gb_bundle *bundle) +{ + struct gb_connection *connection; + struct gb_connection *next; + + list_for_each_entry_safe(connection, next, &bundle->connections, + bundle_links) { + gb_connection_exit(connection); + gb_connection_destroy(connection); + } +} + /* * Tear down a previously set up bundle. */ @@ -224,15 +234,3 @@ found: return bundle; } - -static void gb_bundle_connections_exit(struct gb_bundle *bundle) -{ - struct gb_connection *connection; - struct gb_connection *next; - - list_for_each_entry_safe(connection, next, &bundle->connections, - bundle_links) { - gb_connection_exit(connection); - gb_connection_destroy(connection); - } -} -- 2.7.4