From acf027d2331609d69eec3454a454cb7f5b45b4f5 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Alejandro=20Pi=C3=B1eiro?= Date: Thu, 26 Sep 2019 11:29:42 +0200 Subject: [PATCH] GL43: Use zero for DrawArraysIndirectCommand reserved field The test negative-gshIncompatible-arrays is using a non-zero value for the DrawArraysIndirectCommand reserved field, but quoting its Title, Purpose and Method: "Negative: incompatible the input primitive type of gsh - glDrawArrayIndirect"; "Verify that a driver sets error and no driver crash occurred"; "1. Bind non-zero buffer" "2. Set data" "3. Set wrong geometry shader" "4. Call glDrawArrayIndirect" Testing non-zero values for the reserved field is not one of its objectives. This seems a C&P error. Components: OpenGL VK-GL-CTS issue: 2023 Affects: KHR-GL43.draw_indirect.negative-gshIncompatible-arrays Change-Id: I8f0676b3a82266fa41becdfb720b04893720b6fc --- external/openglcts/modules/gles31/es31cDrawIndirectTests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external/openglcts/modules/gles31/es31cDrawIndirectTests.cpp b/external/openglcts/modules/gles31/es31cDrawIndirectTests.cpp index 8a947d9..265577e 100644 --- a/external/openglcts/modules/gles31/es31cDrawIndirectTests.cpp +++ b/external/openglcts/modules/gles31/es31cDrawIndirectTests.cpp @@ -7168,7 +7168,7 @@ public: indirectArrays.count = static_cast(coords.size()); indirectArrays.primCount = 1; indirectArrays.first = 0; - indirectArrays.reservedMustBeZero = 2312; + indirectArrays.reservedMustBeZero = 0; glGenBuffers(1, &_bufferIndirect); glBindBuffer(GL_DRAW_INDIRECT_BUFFER, _bufferIndirect); -- 2.7.4