From accde6ea166858ba629546c161a25bd60fb392c0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Mon, 26 Sep 2016 12:12:12 +0100 Subject: [PATCH] tests: parse-launch: looks clean nowadays, so re-enable for valgrind Also, the valgrind bits weren't hooked up properly anyway, checking the wrong define. --- tests/check/Makefile.am | 1 - tests/check/pipelines/parse-launch.c | 14 ++------------ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/tests/check/Makefile.am b/tests/check/Makefile.am index 511a60a..1b0ebc4 100644 --- a/tests/check/Makefile.am +++ b/tests/check/Makefile.am @@ -234,7 +234,6 @@ libs_gstnettimeprovider_LDADD = \ VALGRIND_TO_FIX = \ gst/gstinfo \ gst/gsttracerrecord \ - pipelines/parse-launch \ tools/gstinspect VALGRIND_IGNORE = \ diff --git a/tests/check/pipelines/parse-launch.c b/tests/check/pipelines/parse-launch.c index ec30d9c..6472070 100644 --- a/tests/check/pipelines/parse-launch.c +++ b/tests/check/pipelines/parse-launch.c @@ -22,11 +22,6 @@ # include "config.h" #endif -#ifdef HAVE_VALGRIND_H -# include -# include -#endif - #include #define GST_TYPE_PARSE_TEST_ELEMENT (gst_parse_test_element_get_type()) @@ -397,19 +392,14 @@ static const gchar *leaking_failures[] = { NULL }; +/* These don't seem to leak any longer? */ GST_START_TEST (leaking_fail_pipes) { const gchar **s; for (s = leaking_failures; *s != NULL; s++) { - /* Uncomment if you want to try fixing the leaks */ -#if 0 - g_print ("Trying pipe: %s\n", *s); + GST_INFO ("Trying pipe: %s", *s); expected_fail_pipe (*s); -#endif -#ifdef HAVE_VALGRIND_H - VALGRIND_DO_LEAK_CHECK; -#endif } } -- 2.7.4