From ac92944b8a74f8c49ab72bdb24b1eab2fa0055c6 Mon Sep 17 00:00:00 2001 From: ERAMOTO Masaya Date: Thu, 1 Mar 2018 13:27:38 +0900 Subject: [PATCH] unit/test-gdbus-client: Use g_dbus_dict_append_entry() Change-Id: I63b356bd82ffee5f40ba4b53756d384874c7ee59 Signed-off-by: Amit Purwar --- unit/test-gdbus-client.c | 38 +++----------------------------------- 1 file changed, 3 insertions(+), 35 deletions(-) diff --git a/unit/test-gdbus-client.c b/unit/test-gdbus-client.c index 3554d38..17b5eeb 100755 --- a/unit/test-gdbus-client.c +++ b/unit/test-gdbus-client.c @@ -183,39 +183,6 @@ static void client_connect_disconnect(const void *data) context); } -static void append_variant(DBusMessageIter *iter, int type, void *val) -{ - DBusMessageIter value; - char sig[2] = { type, '\0' }; - - dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, sig, &value); - - dbus_message_iter_append_basic(&value, type, val); - - dbus_message_iter_close_container(iter, &value); -} - -static void dict_append_entry(DBusMessageIter *dict, const char *key, int type, - void *val) -{ - DBusMessageIter entry; - - if (type == DBUS_TYPE_STRING) { - const char *str = *((const char **) val); - if (str == NULL) - return; - } - - dbus_message_iter_open_container(dict, DBUS_TYPE_DICT_ENTRY, - NULL, &entry); - - dbus_message_iter_append_basic(&entry, DBUS_TYPE_STRING, &key); - - append_variant(&entry, type, val); - - dbus_message_iter_close_container(dict, &entry); -} - static gboolean get_dict(const GDBusPropertyTable *property, DBusMessageIter *iter, void *data) { @@ -228,8 +195,9 @@ static gboolean get_dict(const GDBusPropertyTable *property, DBUS_TYPE_STRING_AS_STRING DBUS_TYPE_VARIANT_AS_STRING DBUS_DICT_ENTRY_END_CHAR_AS_STRING, &dict); - dict_append_entry(&dict, "String", DBUS_TYPE_STRING, &string); - dict_append_entry(&dict, "Boolean", DBUS_TYPE_BOOLEAN, &boolean); + g_dbus_dict_append_entry(&dict, "String", DBUS_TYPE_STRING, &string); + g_dbus_dict_append_entry(&dict, "Boolean", + DBUS_TYPE_BOOLEAN, &boolean); dbus_message_iter_close_container(iter, &dict); -- 2.7.4