From ac4a50268f205d77eb6b94294915acef9b1d5d6f Mon Sep 17 00:00:00 2001 From: Sascha Silbe Date: Fri, 8 Mar 2019 10:32:19 +0100 Subject: [PATCH] tests: fix possible segfault in cpu-remap-test pa_init_remap_func() takes care to initialise pa_remap_t.do_remap to NULL before calling init_remap_func (the CPU-specific remap init function) and invokes init_remap_c if init_remap_func did not set pa_remap_t.do_remap to non-NULL. remap_init_test_channels() calls init_remap_func() directly so it must make sure pa_remap_t.do_remap is set to NULL. Otherwise we'll end up with a random value in pa_remap_t.do_remap if there is no CPU-optimised remap function for the current operation. --- src/tests/cpu-remap-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/cpu-remap-test.c b/src/tests/cpu-remap-test.c index c4eec45..b4b70b8 100644 --- a/src/tests/cpu-remap-test.c +++ b/src/tests/cpu-remap-test.c @@ -212,7 +212,7 @@ static void remap_init_test_channels( unsigned out_channels, bool rearrange) { - pa_remap_t remap_orig, remap_func; + pa_remap_t remap_orig = {0}, remap_func = {0}; setup_remap_channels(&remap_orig, f, in_channels, out_channels, rearrange); orig_init_func(&remap_orig); -- 2.7.4