From ac1d19208cb97f98ee2d7e21d7fca376feabf78f Mon Sep 17 00:00:00 2001 From: "Djordje.Pesic" Date: Thu, 4 Jun 2015 04:45:08 -0700 Subject: [PATCH] Fix more -Wsign-compare bugs with GCC 4.9.2 Review URL: https://codereview.chromium.org/1152993005 Cr-Commit-Position: refs/heads/master@{#28800} --- test/cctest/test-assembler-mips.cc | 168 ++++++++++++++++++------------------- 1 file changed, 84 insertions(+), 84 deletions(-) diff --git a/test/cctest/test-assembler-mips.cc b/test/cctest/test-assembler-mips.cc index a797328..e880df6 100644 --- a/test/cctest/test-assembler-mips.cc +++ b/test/cctest/test-assembler-mips.cc @@ -3369,28 +3369,28 @@ TEST(class_fmt) { Object* dummy = CALL_GENERATED_CODE(f, &t, 0, 0, 0, 0); USE(dummy); // Expected double results. - CHECK_EQ(bit_cast(t.dSignalingNan), 0x001); - CHECK_EQ(bit_cast(t.dQuietNan), 0x002); - CHECK_EQ(bit_cast(t.dNegInf), 0x004); - CHECK_EQ(bit_cast(t.dNegNorm), 0x008); - CHECK_EQ(bit_cast(t.dNegSubnorm), 0x010); - CHECK_EQ(bit_cast(t.dNegZero), 0x020); - CHECK_EQ(bit_cast(t.dPosInf), 0x040); - CHECK_EQ(bit_cast(t.dPosNorm), 0x080); - CHECK_EQ(bit_cast(t.dPosSubnorm), 0x100); - CHECK_EQ(bit_cast(t.dPosZero), 0x200); + CHECK_EQ(bit_cast(t.dSignalingNan), 0x001); + CHECK_EQ(bit_cast(t.dQuietNan), 0x002); + CHECK_EQ(bit_cast(t.dNegInf), 0x004); + CHECK_EQ(bit_cast(t.dNegNorm), 0x008); + CHECK_EQ(bit_cast(t.dNegSubnorm), 0x010); + CHECK_EQ(bit_cast(t.dNegZero), 0x020); + CHECK_EQ(bit_cast(t.dPosInf), 0x040); + CHECK_EQ(bit_cast(t.dPosNorm), 0x080); + CHECK_EQ(bit_cast(t.dPosSubnorm), 0x100); + CHECK_EQ(bit_cast(t.dPosZero), 0x200); // Expected float results. - CHECK_EQ(bit_cast(t.fSignalingNan), 0x001); - CHECK_EQ(bit_cast(t.fQuietNan), 0x002); - CHECK_EQ(bit_cast(t.fNegInf), 0x004); - CHECK_EQ(bit_cast(t.fNegNorm), 0x008); - CHECK_EQ(bit_cast(t.fNegSubnorm), 0x010); - CHECK_EQ(bit_cast(t.fNegZero), 0x020); - CHECK_EQ(bit_cast(t.fPosInf), 0x040); - CHECK_EQ(bit_cast(t.fPosNorm), 0x080); - CHECK_EQ(bit_cast(t.fPosSubnorm), 0x100); - CHECK_EQ(bit_cast(t.fPosZero), 0x200); + CHECK_EQ(bit_cast(t.fSignalingNan), 0x001); + CHECK_EQ(bit_cast(t.fQuietNan), 0x002); + CHECK_EQ(bit_cast(t.fNegInf), 0x004); + CHECK_EQ(bit_cast(t.fNegNorm), 0x008); + CHECK_EQ(bit_cast(t.fNegSubnorm), 0x010); + CHECK_EQ(bit_cast(t.fNegZero), 0x020); + CHECK_EQ(bit_cast(t.fPosInf), 0x040); + CHECK_EQ(bit_cast(t.fPosNorm), 0x080); + CHECK_EQ(bit_cast(t.fPosSubnorm), 0x100); + CHECK_EQ(bit_cast(t.fPosZero), 0x200); } } @@ -3686,88 +3686,88 @@ TEST(C_COND_FMT) { test.fOp1 = 2.0; test.fOp2 = 3.0; (CALL_GENERATED_CODE(f, &test, 0, 0, 0, 0)); - CHECK_EQ(test.dF, 0); - CHECK_EQ(test.dUn, 0); - CHECK_EQ(test.dEq, 0); - CHECK_EQ(test.dUeq, 0); - CHECK_EQ(test.dOlt, 1); - CHECK_EQ(test.dUlt, 1); - CHECK_EQ(test.dOle, 1); - CHECK_EQ(test.dUle, 1); - CHECK_EQ(test.fF, 0); - CHECK_EQ(test.fUn, 0); - CHECK_EQ(test.fEq, 0); - CHECK_EQ(test.fUeq, 0); - CHECK_EQ(test.fOlt, 1); - CHECK_EQ(test.fUlt, 1); - CHECK_EQ(test.fOle, 1); - CHECK_EQ(test.fUle, 1); + CHECK_EQ(test.dF, 0U); + CHECK_EQ(test.dUn, 0U); + CHECK_EQ(test.dEq, 0U); + CHECK_EQ(test.dUeq, 0U); + CHECK_EQ(test.dOlt, 1U); + CHECK_EQ(test.dUlt, 1U); + CHECK_EQ(test.dOle, 1U); + CHECK_EQ(test.dUle, 1U); + CHECK_EQ(test.fF, 0U); + CHECK_EQ(test.fUn, 0U); + CHECK_EQ(test.fEq, 0U); + CHECK_EQ(test.fUeq, 0U); + CHECK_EQ(test.fOlt, 1U); + CHECK_EQ(test.fUlt, 1U); + CHECK_EQ(test.fOle, 1U); + CHECK_EQ(test.fUle, 1U); test.dOp1 = std::numeric_limits::max(); test.dOp2 = std::numeric_limits::min(); test.fOp1 = std::numeric_limits::min(); test.fOp2 = std::numeric_limits::lowest(); (CALL_GENERATED_CODE(f, &test, 0, 0, 0, 0)); - CHECK_EQ(test.dF, 0); - CHECK_EQ(test.dUn, 0); - CHECK_EQ(test.dEq, 0); - CHECK_EQ(test.dUeq, 0); - CHECK_EQ(test.dOlt, 0); - CHECK_EQ(test.dUlt, 0); - CHECK_EQ(test.dOle, 0); - CHECK_EQ(test.dUle, 0); - CHECK_EQ(test.fF, 0); - CHECK_EQ(test.fUn, 0); - CHECK_EQ(test.fEq, 0); - CHECK_EQ(test.fUeq, 0); - CHECK_EQ(test.fOlt, 0); - CHECK_EQ(test.fUlt, 0); - CHECK_EQ(test.fOle, 0); - CHECK_EQ(test.fUle, 0); + CHECK_EQ(test.dF, 0U); + CHECK_EQ(test.dUn, 0U); + CHECK_EQ(test.dEq, 0U); + CHECK_EQ(test.dUeq, 0U); + CHECK_EQ(test.dOlt, 0U); + CHECK_EQ(test.dUlt, 0U); + CHECK_EQ(test.dOle, 0U); + CHECK_EQ(test.dUle, 0U); + CHECK_EQ(test.fF, 0U); + CHECK_EQ(test.fUn, 0U); + CHECK_EQ(test.fEq, 0U); + CHECK_EQ(test.fUeq, 0U); + CHECK_EQ(test.fOlt, 0U); + CHECK_EQ(test.fUlt, 0U); + CHECK_EQ(test.fOle, 0U); + CHECK_EQ(test.fUle, 0U); test.dOp1 = std::numeric_limits::lowest(); test.dOp2 = std::numeric_limits::lowest(); test.fOp1 = std::numeric_limits::max(); test.fOp2 = std::numeric_limits::max(); (CALL_GENERATED_CODE(f, &test, 0, 0, 0, 0)); - CHECK_EQ(test.dF, 0); - CHECK_EQ(test.dUn, 0); - CHECK_EQ(test.dEq, 1); - CHECK_EQ(test.dUeq, 1); - CHECK_EQ(test.dOlt, 0); - CHECK_EQ(test.dUlt, 0); - CHECK_EQ(test.dOle, 1); - CHECK_EQ(test.dUle, 1); - CHECK_EQ(test.fF, 0); - CHECK_EQ(test.fUn, 0); - CHECK_EQ(test.fEq, 1); - CHECK_EQ(test.fUeq, 1); - CHECK_EQ(test.fOlt, 0); - CHECK_EQ(test.fUlt, 0); - CHECK_EQ(test.fOle, 1); - CHECK_EQ(test.fUle, 1); + CHECK_EQ(test.dF, 0U); + CHECK_EQ(test.dUn, 0U); + CHECK_EQ(test.dEq, 1U); + CHECK_EQ(test.dUeq, 1U); + CHECK_EQ(test.dOlt, 0U); + CHECK_EQ(test.dUlt, 0U); + CHECK_EQ(test.dOle, 1U); + CHECK_EQ(test.dUle, 1U); + CHECK_EQ(test.fF, 0U); + CHECK_EQ(test.fUn, 0U); + CHECK_EQ(test.fEq, 1U); + CHECK_EQ(test.fUeq, 1U); + CHECK_EQ(test.fOlt, 0U); + CHECK_EQ(test.fUlt, 0U); + CHECK_EQ(test.fOle, 1U); + CHECK_EQ(test.fUle, 1U); test.dOp1 = std::numeric_limits::quiet_NaN(); test.dOp2 = 0.0; test.fOp1 = std::numeric_limits::quiet_NaN(); test.fOp2 = 0.0; (CALL_GENERATED_CODE(f, &test, 0, 0, 0, 0)); - CHECK_EQ(test.dF, 0); - CHECK_EQ(test.dUn, 1); - CHECK_EQ(test.dEq, 0); - CHECK_EQ(test.dUeq, 1); - CHECK_EQ(test.dOlt, 0); - CHECK_EQ(test.dUlt, 1); - CHECK_EQ(test.dOle, 0); - CHECK_EQ(test.dUle, 1); - CHECK_EQ(test.fF, 0); - CHECK_EQ(test.fUn, 1); - CHECK_EQ(test.fEq, 0); - CHECK_EQ(test.fUeq, 1); - CHECK_EQ(test.fOlt, 0); - CHECK_EQ(test.fUlt, 1); - CHECK_EQ(test.fOle, 0); - CHECK_EQ(test.fUle, 1); + CHECK_EQ(test.dF, 0U); + CHECK_EQ(test.dUn, 1U); + CHECK_EQ(test.dEq, 0U); + CHECK_EQ(test.dUeq, 1U); + CHECK_EQ(test.dOlt, 0U); + CHECK_EQ(test.dUlt, 1U); + CHECK_EQ(test.dOle, 0U); + CHECK_EQ(test.dUle, 1U); + CHECK_EQ(test.fF, 0U); + CHECK_EQ(test.fUn, 1U); + CHECK_EQ(test.fEq, 0U); + CHECK_EQ(test.fUeq, 1U); + CHECK_EQ(test.fOlt, 0U); + CHECK_EQ(test.fUlt, 1U); + CHECK_EQ(test.fOle, 0U); + CHECK_EQ(test.fUle, 1U); } } -- 2.7.4