From ab782e585f455f89b38589e52b34456dcfe6ff92 Mon Sep 17 00:00:00 2001 From: "verwaest@chromium.org" Date: Mon, 18 Mar 2013 14:31:08 +0000 Subject: [PATCH] Since v8:13964, flags is uint32, so always use cmp on ARM. Review URL: https://chromiumcodereview.appspot.com/12693020 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13967 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/arm/stub-cache-arm.cc | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/arm/stub-cache-arm.cc b/src/arm/stub-cache-arm.cc index e3d27f1..3350c56 100644 --- a/src/arm/stub-cache-arm.cc +++ b/src/arm/stub-cache-arm.cc @@ -102,12 +102,7 @@ static void ProbeTable(Isolate* isolate, uint32_t mask = Code::kFlagsNotUsedInLookup; ASSERT(__ ImmediateFitsAddrMode1Instruction(mask)); __ bic(flags_reg, flags_reg, Operand(mask)); - // Using cmn and the negative instead of cmp means we can use movw. - if (flags < 0) { - __ cmn(flags_reg, Operand(-flags)); - } else { - __ cmp(flags_reg, Operand(flags)); - } + __ cmp(flags_reg, Operand(flags)); __ b(ne, &miss); #ifdef DEBUG -- 2.7.4