From ab77410140d94af9295eaa9ba17fa56df37bd90d Mon Sep 17 00:00:00 2001
From: reichelt <reichelt@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Sat, 5 Aug 2006 23:26:38 +0000
Subject: [PATCH] 	PR c/27721 	* c-typeck.c (build_modify_expr): Test
 earlier for non-lvalues.

	* gcc.dg/lvalue-4.c: New test.


git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@115955 138bc75d-0d04-0410-961f-82ee72b054a4
---
 gcc/ChangeLog                   | 3 +++
 gcc/c-typeck.c                  | 6 +++---
 gcc/testsuite/ChangeLog         | 3 +++
 gcc/testsuite/gcc.dg/lvalue-4.c | 8 ++++++++
 4 files changed, 17 insertions(+), 3 deletions(-)
 create mode 100644 gcc/testsuite/gcc.dg/lvalue-4.c

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 72e1d46..0cbdf6d 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,8 @@
 2006-08-05  Volker Reichelt  <reichelt@igpm.rwth-aachen.de>
 
+	PR c/27721
+	* c-typeck.c (build_modify_expr): Test earlier for non-lvalues.
+
 	PR c/28136
 	* c-parser.c (c_parser_postfix_expression_after_paren_type): Robustify.
 
diff --git a/gcc/c-typeck.c b/gcc/c-typeck.c
index 31dadc6..ff27c97 100644
--- a/gcc/c-typeck.c
+++ b/gcc/c-typeck.c
@@ -3668,6 +3668,9 @@ build_modify_expr (tree lhs, enum tree_code modifycode, tree rhs)
   if (TREE_CODE (lhs) == ERROR_MARK || TREE_CODE (rhs) == ERROR_MARK)
     return error_mark_node;
 
+  if (!lvalue_or_else (lhs, lv_assign))
+    return error_mark_node;
+
   STRIP_TYPE_NOPS (rhs);
 
   newrhs = rhs;
@@ -3681,9 +3684,6 @@ build_modify_expr (tree lhs, enum tree_code modifycode, tree rhs)
       newrhs = build_binary_op (modifycode, lhs, rhs, 1);
     }
 
-  if (!lvalue_or_else (lhs, lv_assign))
-    return error_mark_node;
-
   /* Give an error for storing in something that is 'const'.  */
 
   if (TREE_READONLY (lhs) || TYPE_READONLY (lhstype)
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 99bbfc5..89f1d4a 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,8 @@
 2006-08-05  Volker Reichelt  <reichelt@igpm.rwth-aachen.de>
 
+	PR c/27721
+	* gcc.dg/lvalue-4.c: New test.
+
 	PR c/28136
 	* gcc.dg/init-bad-5.c: New test.
 
diff --git a/gcc/testsuite/gcc.dg/lvalue-4.c b/gcc/testsuite/gcc.dg/lvalue-4.c
new file mode 100644
index 0000000..bc92901
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/lvalue-4.c
@@ -0,0 +1,8 @@
+/* PR c/27721 */
+/* { dg-do compile } */
+
+void foo()
+{
+  int i();
+  i += 0;  /* { dg-error "lvalue required" } */
+}
-- 
2.7.4