From ab12d6ef8fbcc6e6d185bac60412151e843534a1 Mon Sep 17 00:00:00 2001 From: Anup Patel Date: Fri, 8 Feb 2019 09:46:12 +0530 Subject: [PATCH] platform: template: Improve comments for FW_JUMP_ADDR and FW_PAYLOAD_OFFSET Both FW_JUMP_ADDR and FW_PAYLOAD_OFFSET, should be: 1. 4MB aligned for 32bit system 2. 2MB aligned for 64bit system Explicitly specify the above details in config.mk comments for template platform. Signed-off-by: Anup Patel --- platform/template/config.mk | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/platform/template/config.mk b/platform/template/config.mk index 2f2b895..3c85af7 100644 --- a/platform/template/config.mk +++ b/platform/template/config.mk @@ -41,8 +41,13 @@ FW_TEXT_START=0x80000000 # as needed. # FW_JUMP= -# This needs to be 4MB alligned for 32-bit support -FW_JUMP_ADDR=0x80400000 +# This needs to be 4MB aligned for 32-bit support +# This needs to be 2MB aligned for 64-bit support +# ifeq ($(OPENSBI_CC_XLEN), 32) +# FW_JUMP_ADDR=0x80400000 +# else +# FW_JUMP_ADDR=0x80200000 +# endif # FW_JUMP_FDT_ADDR=0x82200000 # @@ -51,8 +56,13 @@ FW_JUMP_ADDR=0x80400000 # as needed. # FW_PAYLOAD= -# This needs to be 4MB alligned for 32-bit support +# This needs to be 4MB aligned for 32-bit support +# This needs to be 2MB aligned for 64-bit support +ifeq ($(OPENSBI_CC_XLEN), 32) FW_PAYLOAD_OFFSET=0x400000 +else +FW_PAYLOAD_OFFSET=0x200000 +endif # FW_PAYLOAD_ALIGN=0x1000 # FW_PAYLOAD_PATH="path to next boot stage binary image file" # FW_PAYLOAD_FDT_PATH="path to platform flattened device tree file" -- 2.7.4