From ab03b63d7a9c7978d51e56c191f0b86888d121dc Mon Sep 17 00:00:00 2001 From: Sripathi Kodi Date: Mon, 20 Sep 2010 23:24:29 +0530 Subject: [PATCH] [virtio-9p] open should not return EBADF When 9P server fails to create a file due to permission problems it should return EPERM. However the current 9P2000.L code returns EBADF. EBADF is NOT a valid return value from open() call. The problem is because we do not preserve the errno variable properly. If the file open had failed, the call to close() on the fd in v9fs_post_lcreate() fails and sets errno to EBADF. We should preserve the errno that we got from open() and we should call close() only if we had a valid fd. Signed-off-by: Sripathi Kodi Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 3b2d49c..3379a30 100644 --- a/hw/virtio-9p.c +++ b/hw/virtio-9p.c @@ -1760,8 +1760,10 @@ static void v9fs_post_lcreate(V9fsState *s, V9fsLcreateState *vs, int err) err = vs->offset; } else { vs->fidp->fid_type = P9_FID_NONE; - close(vs->fidp->fs.fd); err = -errno; + if (vs->fidp->fs.fd > 0) { + close(vs->fidp->fs.fd); + } } complete_pdu(s, vs->pdu, err); -- 2.7.4