From aa94c1e7eed232a54370c6b1f5241de68d0e7412 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Thu, 14 Jul 2016 05:23:15 +0000 Subject: [PATCH] AMDGPU: Fix test not actually testing anything It wasn't actually running the pass, and since it is missing the llvm prefix, the eh intrinsic was not really an IntrinsicInst. Also add missing test for lifetime markers. llvm-svn: 275370 --- .../test/CodeGen/AMDGPU/promote-alloca-lifetime.ll | 24 ++++++++++++++++++++++ .../AMDGPU/promote-alloca-unhandled-intrinsic.ll | 8 ++++---- 2 files changed, 28 insertions(+), 4 deletions(-) create mode 100644 llvm/test/CodeGen/AMDGPU/promote-alloca-lifetime.ll diff --git a/llvm/test/CodeGen/AMDGPU/promote-alloca-lifetime.ll b/llvm/test/CodeGen/AMDGPU/promote-alloca-lifetime.ll new file mode 100644 index 0000000..eeda19f --- /dev/null +++ b/llvm/test/CodeGen/AMDGPU/promote-alloca-lifetime.ll @@ -0,0 +1,24 @@ +; RUN: opt -S -mtriple=amdgcn-unknown-amdhsa -amdgpu-promote-alloca %s | FileCheck -check-prefix=OPT %s + +declare void @llvm.lifetime.start(i64, i8* nocapture) #0 +declare void @llvm.lifetime.end(i64, i8* nocapture) #0 + +; OPT-LABEL: @use_lifetime_promotable_lds( +; OPT-NOT: alloca i32 +; OPT-NOT: llvm.lifetime +; OPT: store i32 %tmp3, i32 addrspace(3)* +define void @use_lifetime_promotable_lds(i32 addrspace(1)* %arg) #2 { +bb: + %tmp = alloca i32, align 4 + %tmp1 = bitcast i32* %tmp to i8* + call void @llvm.lifetime.start(i64 4, i8* %tmp1) + %tmp2 = getelementptr inbounds i32, i32 addrspace(1)* %arg, i64 1 + %tmp3 = load i32, i32 addrspace(1)* %tmp2 + store i32 %tmp3, i32* %tmp + call void @llvm.lifetime.end(i64 4, i8* %tmp1) + ret void +} + +attributes #0 = { argmemonly nounwind } +attributes #1 = { nounwind readnone } +attributes #2 = { nounwind } diff --git a/llvm/test/CodeGen/AMDGPU/promote-alloca-unhandled-intrinsic.ll b/llvm/test/CodeGen/AMDGPU/promote-alloca-unhandled-intrinsic.ll index 7543f2f..e331731 100644 --- a/llvm/test/CodeGen/AMDGPU/promote-alloca-unhandled-intrinsic.ll +++ b/llvm/test/CodeGen/AMDGPU/promote-alloca-unhandled-intrinsic.ll @@ -1,13 +1,13 @@ -; RUN: opt -S -mtriple=amdgcn-unknown-amdhsa < %s | FileCheck %s +; RUN: opt -S -mtriple=amdgcn-unknown-amdhsa -amdgpu-promote-alloca < %s | FileCheck %s ; This is just an arbitrary intrinisic that shouldn't ever need to be ; handled to ensure it doesn't crash. -declare void @eh.sjlj.functioncontext(i8*) #2 +declare void @llvm.stackrestore(i8*) #2 ; CHECK-LABEL: @try_promote_unhandled_intrinsic( ; CHECK: alloca -; CHECK: call void @eh.sjlj.functioncontext(i8* %tmp1) +; CHECK: call void @llvm.stackrestore(i8* %tmp1) define void @try_promote_unhandled_intrinsic(i32 addrspace(1)* %arg) #2 { bb: %tmp = alloca i32, align 4 @@ -15,7 +15,7 @@ bb: %tmp2 = getelementptr inbounds i32, i32 addrspace(1)* %arg, i64 1 %tmp3 = load i32, i32 addrspace(1)* %tmp2 store i32 %tmp3, i32* %tmp - call void @eh.sjlj.functioncontext(i8* %tmp1) + call void @llvm.stackrestore(i8* %tmp1) ret void } -- 2.7.4