From aa8217289864d27b023b31e3efbaa7eb05e77092 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 1 Jan 2020 22:14:33 -0800 Subject: [PATCH] [XRay][test] Fix xray-empty-firstmbb.mir and delete incorrect xray-empty-function.mir xray-empty-firstmbb.mir does not test the intended code path. Change xray-instruction-threshold to 0 to exercise the code path. Delete xray-empty-function.mir . Empty MachineFunction does not work. Various passes (e.g. MachineDominatorTree) assume the presence of an entry block. --- llvm/test/CodeGen/X86/xray-empty-firstmbb.mir | 2 +- llvm/test/CodeGen/X86/xray-empty-function.mir | 13 ------------- 2 files changed, 1 insertion(+), 14 deletions(-) delete mode 100644 llvm/test/CodeGen/X86/xray-empty-function.mir diff --git a/llvm/test/CodeGen/X86/xray-empty-firstmbb.mir b/llvm/test/CodeGen/X86/xray-empty-firstmbb.mir index 5949a4a..e87c865 100644 --- a/llvm/test/CodeGen/X86/xray-empty-firstmbb.mir +++ b/llvm/test/CodeGen/X86/xray-empty-firstmbb.mir @@ -4,7 +4,7 @@ --- | - define i32 @foo() noinline uwtable "xray-instruction-threshold"="1" { + define i32 @foo() noinline uwtable "xray-instruction-threshold"="0" { entry: unreachable } diff --git a/llvm/test/CodeGen/X86/xray-empty-function.mir b/llvm/test/CodeGen/X86/xray-empty-function.mir deleted file mode 100644 index 178771a..0000000 --- a/llvm/test/CodeGen/X86/xray-empty-function.mir +++ /dev/null @@ -1,13 +0,0 @@ -# RUN: llc -run-pass xray-instrumentation -mtriple=x86_64-unknown-linux-gnu -o - %s | FileCheck %s -# -# Make sure we can handle empty functions. ---- -name: empty -tracksRegLiveness: true -liveins: - - { reg: '$edi'} -body: | - bb.0: - ; CHECK-NOT: PATCHABLE_FUNCTION_ENTER -... - -- 2.7.4