From aa6daaafc6ab8b8ed1b0091da12995dfe0e3ed2e Mon Sep 17 00:00:00 2001 From: Mathieu Duponchelle Date: Wed, 10 Oct 2018 23:15:49 +0200 Subject: [PATCH] rtspconnection: do not duplicate authentication headers rtsp_connection_send takes care of adding those already, and some reverse proxies such as nginx will reject the request altogether if the Authorization header is present twice, even with the same value. https://bugzilla.gnome.org/show_bug.cgi?id=797272 --- gst-libs/gst/rtsp/gstrtspconnection.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/gst-libs/gst/rtsp/gstrtspconnection.c b/gst-libs/gst/rtsp/gstrtspconnection.c index 419d543..d134666 100644 --- a/gst-libs/gst/rtsp/gstrtspconnection.c +++ b/gst-libs/gst/rtsp/gstrtspconnection.c @@ -769,7 +769,6 @@ setup_tunneling (GstRTSPConnection * conn, GTimeVal * timeout, gchar * uri, gst_rtsp_message_add_header (msg, GST_RTSP_HDR_CACHE_CONTROL, "no-cache"); gst_rtsp_message_add_header (msg, GST_RTSP_HDR_PRAGMA, "no-cache"); gst_rtsp_message_add_header (msg, GST_RTSP_HDR_HOST, host); - add_auth_header (conn, msg); /* we need to temporarily set conn->tunneled to FALSE to prevent the HTTP * request from being base64 encoded */ @@ -851,7 +850,6 @@ setup_tunneling (GstRTSPConnection * conn, GTimeVal * timeout, gchar * uri, "Sun, 9 Jan 1972 00:00:00 GMT"); gst_rtsp_message_add_header (msg, GST_RTSP_HDR_CONTENT_LENGTH, "32767"); gst_rtsp_message_add_header (msg, GST_RTSP_HDR_HOST, host); - add_auth_header (conn, msg); /* we need to temporarily set conn->tunneled to FALSE to prevent the HTTP * request from being base64 encoded */ -- 2.7.4