From aa60e3c886a95c3909af410e6f2644278aaf502c Mon Sep 17 00:00:00 2001 From: Zachary Turner Date: Wed, 11 Feb 2015 18:21:28 +0000 Subject: [PATCH] Make PipeWindows::CreateWithUniqueName() use GUIDs on Windows. Patch by Adrian McCarthy Differential Revision: http://reviews.llvm.org/D7509 llvm-svn: 228859 --- lldb/cmake/LLDBDependencies.cmake | 1 + lldb/source/Host/windows/PipeWindows.cpp | 22 ++++++++++++++++------ 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/lldb/cmake/LLDBDependencies.cmake b/lldb/cmake/LLDBDependencies.cmake index 0308f12..30b3652 100644 --- a/lldb/cmake/LLDBDependencies.cmake +++ b/lldb/cmake/LLDBDependencies.cmake @@ -69,6 +69,7 @@ if ( CMAKE_SYSTEM_NAME MATCHES "Windows" ) lldbPluginProcessElfCore lldbPluginJITLoaderGDB Ws2_32 + Rpcrt4 ) endif () diff --git a/lldb/source/Host/windows/PipeWindows.cpp b/lldb/source/Host/windows/PipeWindows.cpp index eccc738..3f20cc5 100644 --- a/lldb/source/Host/windows/PipeWindows.cpp +++ b/lldb/source/Host/windows/PipeWindows.cpp @@ -15,6 +15,7 @@ #include #include +#include #include #include @@ -96,14 +97,23 @@ PipeWindows::CreateWithUniqueName(llvm::StringRef prefix, bool child_process_inh { llvm::SmallString<128> pipe_name; Error error; - do { + ::UUID unique_id; + RPC_CSTR unique_string; + RPC_STATUS status = ::UuidCreate(&unique_id); + if (status == RPC_S_OK || status == RPC_S_UUID_LOCAL_ONLY) + status = ::UuidToStringA(&unique_id, &unique_string); + if (status == RPC_S_OK) + { pipe_name = prefix; pipe_name += "-"; - for (unsigned i = 0; i < 6; i++) { - pipe_name += "0123456789abcdef"[llvm::sys::Process::GetRandomNumber() & 15]; - } - Error error = CreateNew(pipe_name, child_process_inherit); - } while (error.GetError() == ERROR_ALREADY_EXISTS); + pipe_name += reinterpret_cast(unique_string); + ::RpcStringFreeA(&unique_string); + error = CreateNew(pipe_name, child_process_inherit); + } + else + { + error.SetError(status, eErrorTypeWin32); + } if (error.Success()) name = pipe_name; return error; -- 2.7.4