From aa32490bfe0b957c4f5583e14304f5e34b2b9bce Mon Sep 17 00:00:00 2001 From: OCHyams Date: Fri, 31 Mar 2023 12:22:02 +0100 Subject: [PATCH] [Assignment Tracking] Enable by default See https://discourse.llvm.org/t/rfc-enable-assignment-tracking/69399 This sets the `-Xclang -fexperimental-assignment-tracking` flag to the value `enabled` which means it will be enabled so long as none of the following are true: it's an LTO build, LLDB debugger tuning has been specified, or it's an O0 build (no work is done in any case if -g is not specified or -gmlt is used). Reviewed By: jmorse Differential Revision: https://reviews.llvm.org/D146987 --- clang/include/clang/Driver/Options.td | 2 +- clang/test/CodeGen/assignment-tracking/flag.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 0cc7052..11007c9 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -5800,7 +5800,7 @@ def experimental_assignment_tracking_EQ : Joined<["-"], "fexperimental-assignmen Group, CodeGenOpts<"EnableAssignmentTracking">, NormalizedValuesScope<"CodeGenOptions::AssignmentTrackingOpts">, Values<"disabled,enabled,forced">, NormalizedValues<["Disabled","Enabled","Forced"]>, - MarshallingInfoEnum, "Disabled">; + MarshallingInfoEnum, "Enabled">; } // let Flags = [CC1Option, NoDriverOption] diff --git a/clang/test/CodeGen/assignment-tracking/flag.cpp b/clang/test/CodeGen/assignment-tracking/flag.cpp index aa1f054..3bd974f 100644 --- a/clang/test/CodeGen/assignment-tracking/flag.cpp +++ b/clang/test/CodeGen/assignment-tracking/flag.cpp @@ -8,10 +8,10 @@ // RUN: -emit-llvm %s -o - -fexperimental-assignment-tracking=disabled -O1\ // RUN: | FileCheck %s --check-prefixes=DISABLE -//// Disabled by default: +//// Enabled by default: // RUN: %clang_cc1 -triple x86_64-none-linux-gnu -debug-info-kind=standalone \ // RUN: -emit-llvm %s -o - -O1 \ -// RUN: | FileCheck %s --check-prefixes=DISABLE +// RUN: | FileCheck %s --check-prefixes=ENABLE //// Disabled at O0 unless forced. // RUN: %clang_cc1 -triple x86_64-none-linux-gnu -debug-info-kind=standalone \ -- 2.7.4